Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: warn when a variable is created an read within the same reaction#16230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
paoloricciuti wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromwarn-read-just-created-state

Conversation

paoloricciuti
Copy link
Member

Closes#16223

Not sure if we should do this but let's discuss...my fear is that it will lead to too much noise in some cases. Also I wonder if it should be DEV only (in dev errors are also better because i can use the labels to give a better indication to the user).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

🦋 Changeset detected

Latest commit:396305a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16230

@gyzerok
Copy link
Contributor

gyzerok commentedJun 25, 2025•
edited
Loading

Do I understand it correctly that it's similar to#16221 in a sense that we are talking about "internal" state here?

Personally based on the same logic I think it should be ok to read state created internally in$derived without a problem.

@paoloricciuti
Copy link
MemberAuthor

Do I understand it correctly that it's similar to#16221 in a sense that we are talking about "internal" state here?

Personally based on the same logic I think it should be ok to read state created internally in$derived without a problem.

Not necessarily internal state...the problem there was that since we were usingsource instead ofstate the derived was actually depending on the newly created state.

Technically in that situation you should get a warning (even tho currently it's not happening, need to figure out why) but the goal of this would be that if you do that by accident you will be notified that something wrong is going on. Still not sure if we should do it tho.

gyzerok reacted with heart emoji

@paoloricciuti
Copy link
MemberAuthor

Mh the reason it's not happening is because we are usingsource instead ofstate (once again lol)...however this means that a similar bug to what you fixed is there for version...let me see if i can build a failing case.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpected$derived behaviour
2 participants
@paoloricciuti@gyzerok
[8]ページ先頭
©2009-2025 Movatter.jp