Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: improve hydration of altered html#16226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
7nik wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromfix-15337
Open

fix: improve hydration of altered html#16226

7nik wants to merge3 commits intomainfromfix-15337

Conversation

7nik
Copy link
Contributor

Closes#15337

Add checks that during hydration we retrieve a right node (should also we checknodeName?) and that we didn't cross the hydration marker.
Also, in case of hydration mismatch insvelte:head, remounts only the head instead of the entire app.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 24, 2025
edited
Loading

🦋 Changeset detected

Latest commit:5545894

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16226

@7nik
Copy link
ContributorAuthor

Having#16248, now I wonder if this PR makes sense. Though, I think remounting only the svelte:head is a good thing.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to set<svelte:head> element withgetAttribute is not a function
1 participant
@7nik

[8]ページ先頭

©2009-2025 Movatter.jp