Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: lift unsafe_state_mutation constraints for SvelteSet and SvelteMap created inside the derived#16221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

gyzerok
Copy link
Contributor

@gyzerokgyzerok commentedJun 24, 2025
edited
Loading

Closes#16211. Changes are mostly tests.

Currently mutating signals local to derived is allowed for primitives, arrays and objects, but not for sets and maps. Since the goal of derived is to be pure, mutating signals created inside it does not violate purity anyhow. This PR makes behavior consistent for sets and maps. Also covering all the other cases with tests to ensure future consistency.

constworks=$derived.by(()=>{letret=$state([])ret.push(1)returnret})constthrows=$derived.by(()=>{letret=newSvelteSet()ret.add(1)returnret})

Update: also applied the change to SvelteDate, SvelteURL and SvelteURLSearchParams

Tests are passing, butpnpm lint is crashing withError: Cannot find module ' /Code/svelte/node_modules/.pnpm/svelte-eslint-parser@0.43.0_svelte@packages+svelte/node_modules/svelte/compiler/index.js'. Not sure what to do about it.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 24, 2025
edited
Loading

🦋 Changeset detected

Latest commit:a784607

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Fedor Nezhivoi added2 commitsJune 24, 2025 10:42
@gyzerokgyzerok changed the titlefix: lift unsafe_state_mutation constrained for SvelteSet and SvelteMap created inside the derivedfix: lift unsafe_state_mutation constraints for SvelteSet and SvelteMap created inside the derivedJun 24, 2025
@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16221

Copy link
Member

@paoloricciutipaoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it makes sense...thanks for exploring and fix this! 🧡

@paoloricciutipaoloricciuti merged commit2af7ba2 intosveltejs:mainJun 24, 2025
10 checks passed
@github-actionsgithub-actionsbot mentioned this pull requestJun 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@paoloricciutipaoloricciutipaoloricciuti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

state_unsafe_mutation where it shouldn't be?
2 participants
@gyzerok@paoloricciuti

[8]ページ先頭

©2009-2025 Movatter.jp