Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: supportusing keyword#16190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Rich-Harris wants to merge3 commits intomainfromusing
Closed

fix: supportusing keyword#16190

Rich-Harris wants to merge3 commits intomainfromusing

Conversation

Rich-Harris
Copy link
Member

@Rich-HarrisRich-Harris commentedJun 17, 2025
edited
Loading

Upgrades to the latest version of Acorn, and replacesecmaVersion: 16 with'latest' which allows Svelte code to use theusing keyword (which is now stage 4, i.e. part of the language).

I didn't think it worthwhile to add a test (would be like having a test forvar declarations or whatever) but you can easily see itworking in the playground once it deploys.

One thing wecould conceivably do is transform components with top-levelusing such that disposals don't occur until the component is removed. This would mean wrapping everything in an async function that ends with something like this:

returnnewPromise((fulfil)=>{$effect(()=>fulfil);});

Personally I'm not sold on the idea — it's a little magical, and would prevent the component from exporting values — but I raise it as a possibility for discussion. If we thought wemight want to add that capability in future we could always prevent the usage of top-levelusing, though that itself might be annoying.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 17, 2025
edited
Loading

🦋 Changeset detected

Latest commit:0fd3921

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16190

@Rich-Harris
Copy link
MemberAuthor

Realised that we don't need to do the whole async dance to get top-levelusing to work as expected in components — opened#16192 as an alternative

@Rich-Harris
Copy link
MemberAuthor

gonna close this in favour of#16192. the peoplehavespoken

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Rich-Harris

[8]ページ先頭

©2009-2025 Movatter.jp