Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: ExportcreateReactiveFunction#15633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
elliott-with-the-longest-name-on-github wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromelliott/create-reactive-function

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-githubelliott-with-the-longest-name-on-github commentedMar 28, 2025•
edited
Loading

TODO:

  • Do we want to do this? (Seems like yes)
  • Is JSDoc good?
  • Tests
  • Should we exportReactiveValue? IMO no, as this seems like the better way to do this, especially when combined with$derived.by, but I'm not completely attached to that opinion
  • Changeset

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

Ocean-OS reacted with thumbs up emojimquandalle reacted with heart emoji
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedMar 28, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:355b9db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15633

Copy link
Member

@dummdidummdummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we expose the underlyingReactiveValue class as well (or instead)?

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@elliott-with-the-longest-name-on-github
Copy link
ContributorAuthor

Yeah I called that out as well -- overall I think the function is more useful (it works with$derived.by like a charm), but it wouldn't hurt to have both...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dummdidummdummdidummdummdidumm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@elliott-with-the-longest-name-on-github@dummdidumm
[8]ページ先頭
©2009-2025 Movatter.jp