Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: thunkify deriveds on the server#14977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
paoloricciuti wants to merge8 commits intomain
base:main
Choose a base branch
Loading
fromthunkify-deriveds-on-server

Conversation

paoloricciuti
Copy link
Member

Closes#14954

I took a shot with the idea of thunkify every derived on the server to make them "work" in case of reassignment. As pointed out by@Rich-Harris this have some downside:

  1. we re-execute possibly expensive deriveds on access
  2. it's still more work than just accessing a variable

But I think regardless of the solution we will go with we will probably need functions in some way so this PR can be a good start.

I got 90% there in 10 minutes and then faced a big problem with destructured deriveds. Since we want every destructured identifier to be a function the only way i thought of is to do something like this.

letstuff=$state({foo:true,bar:[1,2,{baz:'baz'}]});let{ foo,bar:[a,b,{ baz}]}=$derived(stuff);
letstuff={foo:true,bar:[1,2,{baz:'baz'}]};let{foo:foo_1,bar:[a_1,b_1,{baz:baz_1}]}=stuff,foo=()=>foo_1,a=()=>a_1,b=()=>b_1,baz=()=>baz_1;

it's a bit more generated code but it works fine.

Again, this is a proposal, don't know if this the actual direction we want to go but even if it's not it could be a good base.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

Ocean-OS reacted with thumbs up emoji
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJan 10, 2025
edited
Loading

🦋 Changeset detected

Latest commit:b1a6b8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview:https://svelte-dev-git-preview-svelte-14977-svelte.vercel.app/

this is an automated message

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14977

@Rich-Harris
Copy link
Member

Brought this up to speed withmain but there's a problem: now that deriveds are writable, this transformation results in a syntax error (foo?.() = blah is invalid).

Not really sure how best to resolve that so for now I'm not going to try.

@svelte-docs-bot
Copy link

@paoloricciuti
Copy link
MemberAuthor

Brought this up to speed withmain but there's a problem: now that deriveds are writable, this transformation results in a syntax error (foo?.() = blah is invalid).

Not really sure how best to resolve that so for now I'm not going to try.

Yeah i planned to get back to this after the writable deriveds PR but wanted to check if that's the road we want to go first. I can work on this if we want.

@quentinderoubaix
Copy link

any news regarding this@paoloricciuti ?
(was cool to meet you in JSNation 😄)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page.params from $app/state not a rune server-side
3 participants
@paoloricciuti@Rich-Harris@quentinderoubaix

[8]ページ先頭

©2009-2025 Movatter.jp