Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: don't delegate events on custom elements, solve edge case stopPropagation issue#14913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dummdidumm wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromevent-delegation-fixes

Conversation

dummdidumm
Copy link
Member

  • don't delegate events on custom elements
  • still invoke listener for cancelled event on the element where it was cancelled: when you dostopPropagation,event.cancelBubble becomestrue. We can't use this as an indicator to not invoke a listener directly, because the listner could be on the element where propagation was cancelled, i.e. it should still run for that listener. Instead, adjust the event propagation algorithm to detect when a delegated event listener caused the event to be cancelled

fixes#14704

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

Ocean-OS reacted with thumbs up emojiGCastilho reacted with heart emoji
…opagation issue- don't delegate events on custom elements- still invoke listener for cancelled event on the element where it was cancelled: when you do `stopPropagation`, `event.cancelBubble` becomes `true`. We can't use this as an indicator to not invoke a listener directly, because the listner could be on the element where propagation was cancelled, i.e. it should still run for that listener. Instead, adjust the event propagation algorithm to detect when a delegated event listener caused the event to be cancelledfixes#14704
@changeset-botchangeset-bot
Copy link

🦋 Changeset detected

Latest commit:c05abb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14913

@trueadm
Copy link
Contributor

Won't this now break if someone doesstopImmediatePropagation?

@dummdidumm
Copy link
MemberAuthor

Mhm yeah they would fire wrongfully now - whereas they did not fire wrongfully previously.

I see no way to solve both cases other than patching stop(Immediate)Propagation

@GCastilho
Copy link

I've just tested on my repository and confirm it does correct#14704

@Rich-HarrisRich-Harris marked this pull request as draftMay 20, 2025 18:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onclick seems to not be working on web components
3 participants
@dummdidumm@trueadm@GCastilho

[8]ページ先頭

©2009-2025 Movatter.jp