This repository was archived by the owner on Aug 5, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork238
fix(02-advanced-svelte/07-composition): fix invisiblepaper.svg background#582
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@noelforte is attempting to deploy a commit to theSvelte Team onVercel. A member of the Team first needs toauthorize it. |
…svg`When used as a background image, not including a fill will make the svginvisible, this commit adds the fill so the example works properly.Squashed the following changes in as well because the asset was alsobroken in subsequent tutorials. I have aligned them with the changes Imade in `07-composition/01-slots`.
Author
noelforte commentedFeb 15, 2024
Had to check to make sure I wasn't duplicating someone else's work after I made these changes, or if there was some previously raised issue that this pull would close, and came across#502. Seems that there were a few places this issue was still causing problems. Since I adjusted the appearance of the svg in |
paper.svg backgroundpaper.svg backgroundSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught this while going through the tutorial. When used as a background image, not including a fill will make the svg invisible, this commit adds the fill so the example works properly. Have also adjusted the noise
surfaceScaleso the effect is a bit more subtle.Tested in local dev environment to ensure this works as intended.