This repository was archived by the owner on Aug 5, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork238
fix: typed characters to be entered correctly#202
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@tomoam is attempting to deploy a commit to theSvelte Team onVercel. A member of the Team first needs toauthorize it. |
ContributorAuthor
tomoam commentedFeb 2, 2023
@dummdidumm I could fix this. I would appreciate it if you could review it. |
vercelbot commentedFeb 2, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
dummdidumm approved these changesFeb 2, 2023
Member
dummdidumm left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome, thank you so much!
I tested this manually with
- typing something that breaks and unbreaks the output
- navigating around in the iframe
- clicking outside of the editor
and didn't find any bugs. The tests will surely help guard against regressions, too.
ContributorAuthor
tomoam commentedFeb 2, 2023
@dummdidumm Thank you very much! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs:#190 (comment),#190 (comment)
typed
export let data;, but enteredexport let dat;. Theais missing.So, I will create tests to not introduce regressions, and fix this issue.
lack.mov