Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

tutorial#105

Merged
Rich-Harris merged 195 commits intomainfromtutorial-routing
Dec 12, 2022
Merged

tutorial#105

Rich-Harris merged 195 commits intomainfromtutorial-routing
Dec 12, 2022

Conversation

@dummdidumm
Copy link
Member

No description provided.

@vercel
Copy link

vercelbot commentedOct 17, 2022
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated
learn-svelte-dev✅ Ready (Inspect)Visit PreviewDec 12, 2022 at 9:09PM (UTC)

Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com>
…ercise until we can investigate truncated bodies
title: Universal load functions
---

> Coming soon
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This feels rather drastic, and a "coming soon" so early is no good first impression in my opinion.+page/layout.js is a pretty big part of SvelteKit, so not teaching it ... I don't know, that feels wrong. I think it would be better to keep it, or adjust the text and say "let's assume that this is an external API".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yeah, i intend to follow up with stackblitz ASAP about whyfetch is failing in this context. but having magic hidden routes is just a huge no-no in my opinion


onMount(() => {
const interval = setInterval(() => {
+++invalidateAll();+++
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is it on purpose that you only did the+++invalidateAll()+++ and not the---invalidate(..)--- (same question applies to the other invalidate exercises)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it's just unnecessary — it's clear from context what you're supposed to remove. Having the red and the green butting against each other makes for visual chaos, and makes it harder to understand what you're meant to do IMHO

@Rich-HarrisRich-Harris marked this pull request as ready for reviewDecember 12, 2022 21:09
@Rich-HarrisRich-Harris merged commit2ab9dba intomainDec 12, 2022
@Rich-HarrisRich-Harris deleted the tutorial-routing branchDecember 12, 2022 21:09
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

4 more reviewers

@benmccannbenmccannbenmccann left review comments

@Rich-HarrisRich-HarrisRich-Harris left review comments

@tanhauhautanhauhautanhauhau left review comments

@geoffrichgeoffrichgeoffrich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dummdidumm@Rich-Harris@benmccann@swyxio@tanhauhau@geoffrich@vedam

[8]ページ先頭

©2009-2025 Movatter.jp