Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork210
chore: format repository with tabs#740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
dummdidumm commentedJan 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for having a crack at this! When you say "intentionally not included", what do you mean by that? Prettier did format them but you did not include the change? |
only where it's appropriate
Sorry this took a while to get back to, but I think I finally got it! Looking at the main repo for reference, it seems that, |
In some rare cases, prettier will delete some lines in code blocks with Svelte language identifier. Somehow, explicitly setting the sort order helps calm it down. |
Uh oh!
There was an error while loading.Please reload this page.
Originally posted by@dummdidumm in#735 (comment)
Thefirst commit formats all the files using the existing config (for an easier look at the relevant diffs only) and thethird commit formats it again after
useTabs
is changed to true (we can be sure that the diffs are only on the spaces). There's a couple of file extensions intentionally not included likepackage.json
files, which is designed to uses spaces (main repo too)*.md
files, which the Svelte code blocks now gets formatted too and usually usesmarkdownlint to format it as well*.json
files, feels weird to format with tabs and 4 spacesProposed changes
changetabWidth
to 2 as welladdmarkdownlint config file to format markdowns