Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Tentative Vitest#2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jycouet wants to merge14 commits intosveltejs:master
base:master
Choose a base branch
Loading
fromjycouet:deps/vitest
Open

Tentative Vitest#2711

jycouet wants to merge14 commits intosveltejs:masterfromjycouet:deps/vitest

Conversation

jycouet
Copy link
Contributor

In order to have#2706 we probably need to go tovitest and manage wellESM.

Also linked with this issue:#2031


Just started small to see if it's the good direction.
svelte2tsx test script is callingmocha &vitest and when tests are ok in vitest, Iskip them in mocha.
So that the diff is approachable.

What do you think ?

@dummdidumm
Copy link
Member

Don't fully understand the skip thing - I don't have any opinion on how you wanna approach this, the end result of using Vitest instead of Mocha to run the tests (without adjusting any of the tests, ideally) is what counts.

jycouet reacted with thumbs up emoji

@jycouet
Copy link
ContributorAuthor

Forget about the skip thing 😅

Here is what I have locally atm:
image

The346 are green! 🎉

@dummdidumm
Copy link
Member

dummdidumm commentedMar 19, 2025
edited
Loading

Thank you for tackling this!
Seems like this for some reason made the language server tests fail

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jycouet@dummdidumm

[8]ページ先頭

©2009-2025 Movatter.jp