- Notifications
You must be signed in to change notification settings - Fork0
ci: simplify release workflow and improve Go setup#87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Remove the global GO environment variable and streamline the releaseworkflow by specifying the Go version directly from go.mod in thesetup-go action. This reduces duplication and potential version drift.Also, clean up unnecessary steps and comments to make the workflowmore concise and maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR simplifies the release workflow by eliminating the globalGO env var, pulling the Go version directly fromgo.mod, and cleaning up redundant steps and comments.
- Drop
env: GOand switchsetup-gotogo-version-file: go.mod - Inline checkout/setup actions without extra env indirection
- Remove unnecessary blank lines and streamline comments
Comments suppressed due to low confidence (2)
.github/workflows/release.yaml:18
- [nitpick] Consider adding an explicit
name:for the checkout step (e.g.,name: Checkout repository) to improve readability and consistency in workflow logs.
- - uses: actions/checkout@v4.2.2 # immutable action, safe to use a version instead of hashtag.github/workflows/release.yaml:19
- [nitpick] It may help maintain consistency to add a
name:field for the Go setup step (e.g.,name: Setup Go environment), making the workflow easier to scan.
- - uses: actions/setup-go@v5.5.0 # immutable action, safe to use a version instead of hashtagfe891f2 intomainUh oh!
There was an error while loading.Please reload this page.
Remove the global GO environment variable and streamline the release
workflow by specifying the Go version directly from go.mod in the
setup-go action. This reduces duplication and potential version drift.
Also, clean up unnecessary steps and comments to make the workflow
more concise and maintainable.