- Notifications
You must be signed in to change notification settings - Fork14
Improve Typescript React support#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I use vim-coc and looks like it sets filetype typescriptreact for tsx files.Anyways I'm keeping previous functionality just in case somebody used it. For my current setup the implementation is much simple.```let g:context#commentstring#table['typescriptreact'] = { \ 'tsxRegion': '{/*%s*/}' \}```👋 |
Hi. Thank you for the patch, and sorry for not replying before. I don't use vim so heavily nowadays, and certainly I don't do HTML stuff, pretty much at all. I wasn't already confident with the patch I accepted before, and even less with this one (because I don't know how to test it, and I'm quite confused with the technologies). Do you mind if I ask you a few questions? It's fine if you don't know them all.
Thank you. |
While this can't be merged now due to the conflicts (I've pushed some changes), let me know which syntax highlighting are using, and I'll look into fixing this myself if you don't find the time. I'm struggling to find out which syntaxes might be the most popular ones to ship defaults here. Although I'm also considering that I should leave this to users to extend themselves in their config (it's just a line of code to extend the variable), because if there are too many different options, it's just not going to work well. Each user will need to adjust to their syntax. |
Arelav commentedJun 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry. I have seen your message but had no time to immediately respond. Like:
|
I use vim-coc and looks like it sets filetype typescriptreact for tsx files.
Anyways I'm keeping previous functionality just in case somebody used it. For my current setup the implementation is much simple.