Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: port remaining squawk rules#508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
psteinroe merged 26 commits intomainfromfeat/squawk-rules
Sep 18, 2025
Merged

feat: port remaining squawk rules#508

psteinroe merged 26 commits intomainfromfeat/squawk-rules
Sep 18, 2025

Conversation

@psteinroe
Copy link
Collaborator

@psteinroepsteinroe commentedSep 10, 2025
edited
Loading

will have claude do the work over night

closes#131

will porthttps://github.com/kaaveland/eugene/blob/main/eugene/src/lints/rules.rs afterwards

also added a newagentic/ dir and two newjust commands to standardise as well as track the prompts for such work.

UPDATE:

  • refactored some of the rules to make them easier to consume.
  • added a bunch of tests
  • refactored the test framework to allow multiple statements per file (required to test some rules)
  • refactored the test framework to require explicit declaring each expected diagnostic
  • migratedprefer jsonb from eugene too. the remaining ones are either covered be squawk or require a bit more updates to the file context. will do them in a follow-up. see full comparison here:Check eugene lint for migration lint rules? #305 (reply in thread)

@psteinroepsteinroe marked this pull request as draftSeptember 10, 2025 06:17
@psteinroepsteinroe marked this pull request as ready for reviewSeptember 12, 2025 08:53
justfile Outdated
tail -f $(ls $PGT_LOG_PATH/server.log.* | sort -t- -k2,2 -k3,3 -k4,4 | tail -n1)

agenticname:
unset ANTHROPIC_API_KEY&& claude --dangerously-skip-permissions -p"please read agentic/{{name}}.md and follow the instructions closely"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not sure we should commit this into an open source repo – seems like a vulnerability for prompt injection :)
We could pass a --settingsagentic/{{name}}.settings.json file ?

Also, I'm curious: Why do you unset the API key here? To force somebody to login?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

how would that be an attack vector?

I am removing the env because otherwise it doesn't pick up the Max subscription but the API key (which is usage based)

Copy link
Collaborator

@juleswritescodejuleswritescodeSep 18, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am removing the env because otherwise it doesn't pick up the Max subscription but the API key (which is usage based)

ah i see! that makes sense.

how would that be an attack vector?

for example if a malicious contributor adds something into a build script that replaces the contents of youragentic/ file. If you then run the agentic file, claude might dostuff you don't expect – with GH permissions, claude might even push unreviewd commits to master etc

If we review everything closely, that won't be an issue, but I could see that someone contributes aC file or something that we just gloss over

Of course, this would still happen if you run--dangerously-skip-permissions via your own terminal, but then at least nobody would know that we use that param 😇

Your call!

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good point, I just commented them out for now with a node 'use at your own risk'

@psteinroepsteinroe merged commit41d5a8d intomainSep 18, 2025
8 checks passed
@juleswritescodejuleswritescode deleted the feat/squawk-rules branchOctober 28, 2025 15:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@juleswritescodejuleswritescodejuleswritescode approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Analyser Rules from Squawk

3 participants

@psteinroe@juleswritescode

[8]ページ先頭

©2009-2025 Movatter.jp