- Notifications
You must be signed in to change notification settings - Fork102
refactor: simplify caches#448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
juleswritescode left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice :)
Document-level caches would accumulate indefinitely as users edited files.
I'm curious, is this a bug with the lib? Or what happens there?
this is just a follow-up of the change refactoring. before, we were removing data from the parse caches ( I then researched a bit about dash map and replaced it in other places with a more suitable store. |
c06ab00
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fixes unbounded memory caches that could lead to oom issues. Document-level caches would accumulate indefinitely as users edited files.
replaced all DashMap usages with appropriate data structures based on access patterns:
Bounded Memory Caches (LRU):
Read-Heavy Workloads (RwLock):