Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: broken text after receiving batched changes#413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
psteinroe merged 6 commits intomainfromfix/bug
Jun 10, 2025
Merged

Conversation

psteinroe
Copy link
Collaborator

@psteinroepsteinroe commentedJun 2, 2025
edited
Loading

This might be the simplest and weirdest fix of all time.

Again, the core issue is that when we receive batched change params, the ranges are always relative to the original state. This is why we offset them after each. While this is required for our statement range logic to work, it breaks the change tracking for changes to the text. Here, we need to use the un-adjusted range.

So yeah, all in all this needs a serious refactor at some point :D

had to update two tests because turns out their data was wrong - the new one is freshly taken from VSCode (neovim never sends batched changes).

@psteinroepsteinroe marked this pull request as ready for reviewJune 5, 2025 07:19
@psteinroepsteinroe changed the titlefix: crashfix: broken text after receiving batched changesJun 5, 2025
@psteinroepsteinroe marked this pull request as draftJune 5, 2025 07:38
@psteinroepsteinroe removed the request for review fromjuleswritescodeJune 5, 2025 07:38
@psteinroepsteinroe marked this pull request as ready for reviewJune 10, 2025 06:10
Copy link
Collaborator

@juleswritescodejuleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess it looks good to me 😆

@psteinroepsteinroe merged commit4cb12df intomainJun 10, 2025
7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@juleswritescodejuleswritescodejuleswritescode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@psteinroe@juleswritescode

[8]ページ先頭

©2009-2025 Movatter.jp