May 24, 2025 · May 24, 2025 · May 24, 2025 · May 24, 2025
diff --git a/...b0ce33a0002d170200d77afeee60a7977278.json → ...944b9d45eb6c60d7eece8878ed26b3530484.json b/...b0ce33a0002d170200d77afeee60a7977278.json → ...944b9d45eb6c60d7eece8878ed26b3530484.json
diff --git a/crates/pgt_completions/src/providers/columns.rs b/crates/pgt_completions/src/providers/columns.rs
            description: format!("Table: {}.{}", col.schema_name, col.table_name),
            kind: CompletionItemKind::Column,
            completion_text: None,
            detail:Some(col.type_name.to_string()),
            detail: col.type_name.as_ref().map(|t| t.to_string()),
        };

        // autocomplete with the alias in a join clause if we find one
diff --git a/crates/pgt_schema_cache/src/columns.rs b/crates/pgt_schema_cache/src/columns.rs

    pub schema_name: String,
    pub type_id: i64,
    pub type_name: String,
    pub type_name:Option<String>,
    pub is_nullable: bool,

    pub is_primary_key: bool,
diff --git a/crates/pgt_schema_cache/src/queries/columns.sql b/crates/pgt_schema_cache/src/queries/columns.sql
  and atts.attnum = ix.attnum
  left join pg_catalog.pg_attrdef def on atts.attrelid = def.adrelid
  and atts.attnum = def.adnum
  left join pg_catalog.pg_type tps ontps.oid =atts.atttypid
  left join pg_catalog.pg_type tps onatts.atttypid =tps.oid
 where
  -- system columns, such as `cmax` or `tableoid`, have negative `attnum`s
  atts.attnum >= 0
  atts.attnum >= 0 and atts.atttypid is not null and tps.oid is not null
 order by
  schema_name desc,
  table_name,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,7 +20,7 @@ pub fn complete_columns<'a>(ctx: &CompletionContext<'a>, builder: &mut Completio
		description: format!("Table: {}.{}", col.schema_name, col.table_name),
		kind: CompletionItemKind::Column,
		completion_text: None,
		detail:Some(col.type_name.to_string()),
		detail: col.type_name.as_ref().map(\|t\| t.to_string()),
		};

		// autocomplete with the alias in a join clause if we find one
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -48,7 +48,7 @@ pub struct Column {

		pub schema_name: String,
		pub type_id: i64,
		pub type_name: String,
		pub type_name:Option<String>,
		pub is_nullable: bool,

		pub is_primary_key: bool,
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -52,10 +52,10 @@ from
		and atts.attnum = ix.attnum
		left join pg_catalog.pg_attrdef def on atts.attrelid = def.adrelid
		and atts.attnum = def.adnum
		left join pg_catalog.pg_type tps ontps.oid =atts.atttypid
		left join pg_catalog.pg_type tps onatts.atttypid =tps.oid
		where
		-- system columns, such as `cmax` or `tableoid`, have negative `attnum`s
		atts.attnum >= 0
		atts.attnum >= 0 and atts.atttypid is not null and tps.oid is not null
		order by
		schema_name desc,
		table_name,
Expand Down