Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(completions): complete right columns right after JOIN ON#390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
juleswritescode merged 2 commits intomainfromfix/join-on
May 6, 2025

Conversation

juleswritescode
Copy link
Collaborator

Before, we were only completing columns in a JOIN in a "Binary Expression".
But for TreeSitter to recognize a Binary Expression, we need an= sign.

So this wouldn't complete, since there's no= sign:
select * from users u join posts p on u.{}

Now, we're checking for theON node, and completing columns if we're after it.

Note: Multiple joins are each individual join clauses with their own separate ON nodes, so there's no intereference:

select*from users ujoin posts ponu.id=post.user_id-- join clause 1join {}-- join clause 2

We won't autocompete a column, since there's no ON node in join cluase 2 🥳

Comment on lines +351 to +352
// sadly, we need to manually iterate over the children –
// `node.child_by_field_id(..)` does not work as expected
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we might wanna fix this upstream at some point

psteinroe reacted with thumbs up emoji
@juleswritescodejuleswritescode merged commit5945c1b intomainMay 6, 2025
7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@psteinroepsteinroepsteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@juleswritescode@psteinroe

[8]ページ先頭

©2009-2025 Movatter.jp