Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: properly handle multiple changes at once#389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
psteinroe merged 5 commits intomainfromfix/multiple-changes
May 6, 2025

Conversation

psteinroe
Copy link
Collaborator

@psteinroepsteinroe commentedMay 5, 2025
edited
Loading

multiple changes at once happen during search and replace operations.

Right now, we are handling each individually, one after another. this breaks starting at the second change because the range of each change is always related to the original state, not the previous. after fiddling with theapply_change method I figured this solution is the easiest. it expects that all changes are ordered properly, but afaik that's reasonable. if not and we receive bug reports, we can simply sort them.

EDIT: ahh I need to handle the deletions case too! ✅

@psteinroepsteinroe marked this pull request as draftMay 5, 2025 18:45
@psteinroepsteinroe removed the request for review fromjuleswritescodeMay 5, 2025 18:45
@psteinroepsteinroe marked this pull request as ready for reviewMay 6, 2025 06:07
Copy link
Collaborator

@juleswritescodejuleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, jesus! :D

@psteinroepsteinroe merged commit6469ce3 intomainMay 6, 2025
7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@juleswritescodejuleswritescodejuleswritescode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@psteinroe@juleswritescode

[8]ページ先頭

©2009-2025 Movatter.jp