- Notifications
You must be signed in to change notification settings - Fork102
fix: extract sql fn body properly#346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| let stmts = d.iter(DefaultMapper).collect::<Vec<_>>(); | ||
| assert_eq!(stmts.len(), 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Love it!
should we add a test asserting the content as well?
and maybe a test using the $$ notation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not really necessary imo - we can trust pg_query here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
will do it in a follow up
d33bc4f intomainUh oh!
There was an error while loading.Please reload this page.
turns out I was so focused on the rewrite of that layer that I forgot to add even a single test for the sql fn body extraction 😢
fixes#342