Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: simplify parser ?#330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
psteinroe merged 17 commits intomainfromrefactor/parser
Apr 12, 2025
Merged

refactor: simplify parser ?#330

psteinroe merged 17 commits intomainfromrefactor/parser
Apr 12, 2025

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescodejuleswritescode commentedApr 12, 2025
edited
Loading

This is just a suggestion! When looking into the parser, I was sometimes confused by some variable names. Maybe this reduces cognitive load?

  1. Some renamings:
    next_pos tocurrent_pos (it's actually current_pos)
    peek() tocurrent() (peek and look_ahead seemed to do the same)

  2. Removedeat, since it was only used once

  3. Added ais_relevant method which is more readable than!is_irrelevant (to me at least)

and 4. Changed some manualloops to Rust native iterators

Again, just a suggestion – the code was already great, and I don't want to be too invasive 🙌

@juleswritescodejuleswritescode changed the titlerefactor: simplify parserrefactor: simplify parser ?Apr 12, 2025
Copy link
Collaborator

@psteinroepsteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

makes sense!

@psteinroepsteinroe merged commit70f0c93 intomainApr 12, 2025
7 checks passed
@psteinroepsteinroe mentioned this pull requestApr 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@psteinroepsteinroepsteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@juleswritescode@psteinroe

[8]ページ先頭

©2009-2025 Movatter.jp