- Notifications
You must be signed in to change notification settings - Fork102
refactor: parser#322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
refactor: parser#322
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great PR! :)
I was scared that accomodating nested statements would make things more complex, but this even makes it simpler!!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
crates/pgt_workspace/src/workspace/server/statement_identifier.rs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
crates/pgt_workspace/src/workspace/server/statement_identifier.rs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
@juleswritescode for me ParsedDocument or DocumentParse makes more sense than ParsedStatements |
4867189
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
this rewires the workspace server for better DX and adds support for sql function bodies.
closes#178
hear me out:
Document
is responsible for extracting statements from a source file. right now, this is always SQL, but in the future we could make this generic.Parser
is the new layer between the workspace server and the document. there is one parser per document, and the parser owns the document.parser.iter(ExecuteStatementMapper, CursorPositionFilter::new(pos))
and gets exactly the data it needs.