Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: properly trim statement#313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
juleswritescode merged 10 commits intomainfromfix/statement-trim
Apr 6, 2025
Merged

Conversation

juleswritescode
Copy link
Collaborator

Before, changingselect * from toselect * from resultet in aModifiedStatement.new_stmt_text === 'select * fro (the m was accidentally trimmed).

This was because we subtracted the diff_size from the end of the new statement, even if the diff range wasn't included in the new statement anymore.

This PR fixes it :)

psteinroe reacted with heart emoji
Copy link
Collaborator

@psteinroepsteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great catch!

juleswritescodeand others added5 commitsApril 6, 2025 15:37
Co-authored-by: Philipp Steinrötter <philipp@steinroetter.com>
Co-authored-by: Philipp Steinrötter <philipp@steinroetter.com>
Co-authored-by: Philipp Steinrötter <philipp@steinroetter.com>
@juleswritescodejuleswritescode merged commit7278f90 intomainApr 6, 2025
7 checks passed
@psteinroepsteinroe mentioned this pull requestApr 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@psteinroepsteinroepsteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@juleswritescode@psteinroe
[8]ページ先頭
©2009-2025 Movatter.jp