Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: execute statement reliable#291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
psteinroe merged 6 commits intomainfromfix/exec-stmt-cond
Apr 3, 2025
Merged

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescodejuleswritescode commentedApr 1, 2025
edited
Loading

I've been through many iterations but this seems to be the simplest.

We use a dedicated connection for theprepare statement and close it on drop. This will clear all the prepared statements for that session.sqlx itself doesn't cache anything when usingprepare. If we worry about performance overhead, I suggest we a) use sqlx cache viaprepare_with and b) debounce the publishing of diagnostics again 👍

Copy link
Collaborator

@psteinroepsteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

after the ordering was removed this makes me very happy! there is one unused import but other than that great job!

@psteinroepsteinroe merged commitc87d6a4 intomainApr 3, 2025
7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@psteinroepsteinroepsteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@juleswritescode@psteinroe

[8]ページ先頭

©2009-2025 Movatter.jp