Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(adminapi): update adminapi to disable caching on internal metrics endpoint#1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JGjorgji
Copy link
Contributor

@JGjorgjiJGjorgji commentedDec 19, 2025•
edited by coderabbitaibot
Loading

Part of INOPS-673

What kind of change does this PR introduce?

This will disable caching on /metrics/aggregated.

What is the current behavior?

Configurable caching shared by customer collection endpoint.

Summary by CodeRabbit

  • Chores
    • Updated admin API component to version 0.95.1.

✏️ Tip: You can customize this high-level summary in your review settings.

Part of INOPS-673This will disable caching on /metrics/aggregated.
@JGjorgjiJGjorgji requested review froma team ascode ownersDecember 19, 2025 16:35
@coderabbitai
Copy link

coderabbitaibot commentedDec 19, 2025•
edited
Loading

Walkthrough

A single version bump updates theadminapi_release variable in the Ansible configuration from version 0.94.0 to 0.95.1, reflecting a minor release upgrade for the admin API.

Changes

Cohort / File(s)Summary
Version Bump
ansible/vars.yml		Updatedadminapi_release from "0.94.0" to "0.95.1"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line configuration change with no logic implications
  • Version number bump only; no structural or behavioral modifications

Poem

🐰 From zero-nine-four to zero-nine-five,
A version bump keeps the API alive!
A simple update, clean and small,
One line changed—that's all, that's all! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title accurately describes the main change: updating adminapi to disable caching on the internal metrics endpoint, which aligns with the version bump from 0.94.0 to 0.95.1.
Description check✅ PassedThe PR description provides context (INOPS-673), explains the change (disable caching on /metrics/aggregated), and describes current vs. desired behavior, though it does not fully follow the repository's template structure with multiple sub-templates.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branchgjorgjijankovski/inops-673-disable-caching-on-metricsaggregated-endpoint
📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and betweend98ae95 and1a507ec.

📒 Files selected for processing (1)
  • ansible/vars.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: nix-eval / eval
🔇 Additional comments (1)
ansible/vars.yml (1)

56-56:Version bump looks correct; verify the adminapi release contains the expected changes.

The version bump format is appropriate. However, please confirm that adminapi version 0.95.1 exists and includes the caching fix for the/metrics/aggregated endpoint mentioned in INOPS-673.

Comment@coderabbitai help to get the list of available commands and usage tips.

@JGjorgjiJGjorgji added this pull request to themerge queueDec 19, 2025
Merged via the queue intodevelop with commit431bbc6Dec 19, 2025
45 of 46 checks passed
@JGjorgjiJGjorgji deleted the gjorgjijankovski/inops-673-disable-caching-on-metricsaggregated-endpoint branchDecember 19, 2025 20:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pcncpcncpcnc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JGjorgji@pcnc
[8]ページ先頭
©2009-2025 Movatter.jp