Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork221
refactor: Standardize WAL-G config inclusion#1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The `read-replica.conf` file has been moved from `/etc/postgresql-custom/` to `/etc/postgresql-custom/conf.d/`. This change aligns with the standard practice of including configuration snippets from a `conf.d` directory.Changes include:- Dockerfiles: Adjusted to remove direct copy and update `sed` commands.- Ansible: Renamed configuration file and updated task to place it in `conf.d`.- Nix: Updated paths and substitutions to reflect the new location.
Updates the following versions for improved security and stability:- PostgreSQL 17 (orioledb-17) to 17.6.0.015- PostgreSQL 17 to 17.6.1.058- PostgreSQL 15 to 15.14.1.058Also updates the checksum for Pgbouncer 1.19.0.
…-260* 'INDATA-260' of github.com:supabase/postgres:
depends on#1956- WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`.- This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories.- Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed.- PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
pashkinelfe approved these changesDec 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR refactors WAL-G configuration management to follow PostgreSQL's standard practice of including configuration files fromconf.d subdirectories, rather than explicitly includingwal-g.conf inpostgresql.conf.
Key changes:
- WAL-G configuration now resides in
/etc/postgresql-custom/conf.d/wal-g.confinstead of/etc/postgresql-custom/wal-g.conf - PostgreSQL
archive_modeandarchive_commandare now explicitly set in the main configuration file with a no-op command - Direct inclusion of
wal-g.confinpostgresql.confhas been removed
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ansible/tasks/setup-wal-g.yml | Updates WAL-G config deployment to useconf.d directory and removes explicit inclusion logic |
| ansible/files/postgresql_config/postgresql.conf.j2 | Adds explicitarchive_mode = on and no-oparchive_command, removes WAL-G include directive |
| ansible/files/postgresql_config/conf.d/wal-g.conf | Reorganizes configuration settings and removes redundantarchive_mode declaration |
| Dockerfile-orioledb-17 | Removes WAL-G config copy and inclusion sed command |
| Dockerfile-17 | Removes WAL-G config copy and inclusion sed command |
| Dockerfile-15 | Removes WAL-G config copy and inclusion sed command |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Merged via the queue intodevelop with commitDec 9, 2025
7d4bbf0 28 checks passed
Uh oh!
There was an error while loading.Please reload this page.
yvan-sraka pushed a commit that referenced this pull requestDec 9, 2025
* refactor: Move read-replica.conf to conf.dThe `read-replica.conf` file has been moved from `/etc/postgresql-custom/` to `/etc/postgresql-custom/conf.d/`. This change aligns with the standard practice of including configuration snippets from a `conf.d` directory.Changes include:- Dockerfiles: Adjusted to remove direct copy and update `sed` commands.- Ansible: Renamed configuration file and updated task to place it in `conf.d`.- Nix: Updated paths and substitutions to reflect the new location.* chore: Update postgres and pgbouncer versionsUpdates the following versions for improved security and stability:- PostgreSQL 17 (orioledb-17) to 17.6.0.015- PostgreSQL 17 to 17.6.1.058- PostgreSQL 15 to 15.14.1.058Also updates the checksum for Pgbouncer 1.19.0.* refactor: Standardize WAL-G config inclusiondepends on#1956- WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`.- This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories.- Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed.- PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on#1956
✅ docker build
✅ flake check