Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork221
feat: reduction of closure size for plv8#1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+8 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
hunleyd approved these changesNov 17, 2025
jchancojr approved these changesNov 17, 2025
Contributor
jchancojr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm ty so much
Merged via the queue intodevelop with commitNov 18, 2025
7c2878c 28 checks passed
Uh oh!
There was an error while loading.Please reload this page.
hunleyd added a commit that referenced this pull requestNov 18, 2025
* 'develop' of github.com:supabase/postgres: feat: reduciton of closure size for plv8 (#1925)
hunleyd added a commit that referenced this pull requestNov 18, 2025
* 'develop' of github.com:supabase/postgres: feat: reduciton of closure size for plv8 (#1925)
hunleyd added a commit that referenced this pull requestDec 1, 2025
* origin/develop: chore: bump Wrappers version to 0.5.7 (#1945) chore: bump versions (#1949) Revert "docs: create an automated changlog file that shows up in release file…" (#1948) chore: remove precreated Storage objects (#1911) refactor: Move PostgreSQL auto_explain config to conf.d (#1943) docs: create an automated changlog file that shows up in release files (#1793) fix: removing dead nix code (#1946) docs: expansion to help understand anatomy and code api in user here (#1944) fix: try to use mirror fallbacks for docker images (#1942) feat: need this workflow present to test (#1941) feat: Add PostgreSQL conf.d directory (#1929) [jj-spr] initial version (#1866) chore: upgrade supabase-admin-agent (#1935) fix: garbage collect after every profile intall + remove osquery (#1938) fix(ci): limit max-jobs of nix to 8 to prevent OOM while running nix flake check (#1933) Revert "fix: disable temporary Nix checks on aarch64-linux" (#1934) fix: adaptive retry on aws (#1917) fix: disable temporary Nix checks on aarch64-linux (#1930) feat: release orioledb with rewind functionality (#1880) feat: reduciton of closure size for plv8 (#1925)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced the closure size (total dependency footprint) of the plv8 PostgreSQL extension by optimizing its runtime dependencies.
What was changed:
- Added libcxx to the function inputs
- Updated 4 locations where runtime library paths are set (both Darwin/macOS and Linux paths)
- This reduces closure size because stdenv.cc.cc.lib pulls in the entire compiler toolchain, while libcxx only brings in the C++ standard library