Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: test pg_upgrade compatibility with older extension versions#1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jfroche wants to merge4 commits intodevelop
base:develop
Choose a base branch
Loading
fromfeat/test-pg-upgrade-older-version

Conversation

@jfroche
Copy link
Collaborator

@jfrochejfroche commentedNov 6, 2025
edited
Loading

Add test to verify that all extension versions from PostgreSQL 15 can successfully upgrade to PostgreSQL 17 using pg_upgrade.

The test now validates:

  • Each PG 15 extension version can be upgraded to PG 17
  • Extension update scripts are properly generated during upgrade
  • Version handling works correctly with and without update scripts
  • Final extension versions match expected values after upgrade

samrose reacted with rocket emoji
@samrosesamrose self-requested a reviewNovember 6, 2025 20:29
Copy link
Collaborator

@samrosesamrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! Will just need to test before we merge it

@jfrochejfroche marked this pull request as ready for reviewNovember 6, 2025 22:57
@jfrochejfroche requested review froma team ascode ownersNovember 6, 2025 22:57
@jfrochejfrocheforce-pushed thefeat/test-pg-upgrade-older-version branch from8acfa60 tof59c791CompareNovember 7, 2025 16:33
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch fromf59c791 to779090bCompareNovember 11, 2025 16:17
@yvan-srakayvan-sraka self-assigned thisNov 11, 2025
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch 2 times, most recently from24d66bb to164f401CompareNovember 19, 2025 10:13
@yvan-srakayvan-sraka marked this pull request as draftNovember 19, 2025 21:13
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch from164f401 to450b690CompareNovember 21, 2025 10:38
@yvan-srakayvan-sraka marked this pull request as ready for reviewNovember 21, 2025 13:03
@blacksmith-sh

This comment has been minimized.

@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch fromf6f9d9b to9beb48aCompareNovember 25, 2025 16:11
@yvan-srakayvan-sraka changed the base branch fromdevelop tocustom-github-runnersNovember 25, 2025 16:11
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch from9beb48a to218357aCompareNovember 25, 2025 17:46
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch 2 times, most recently from971248f to84cfa8dCompareNovember 25, 2025 23:28
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch 2 times, most recently from39db71b to29a4d56CompareNovember 26, 2025 11:33
@yvan-srakayvan-srakaforce-pushed thecustom-github-runners branch 2 times, most recently from03dc754 toc159bb6CompareDecember 1, 2025 10:01
@jfrochejfrocheforce-pushed thecustom-github-runners branch 3 times, most recently fromdf5545b tob9294eeCompareDecember 2, 2025 21:26
@jfrochejfrocheforce-pushed thecustom-github-runners branch 24 times, most recently from182d513 to1246b61CompareDecember 8, 2025 13:43
Base automatically changed fromcustom-github-runners todevelopDecember 8, 2025 17:15
jfrocheand others added4 commitsDecember 11, 2025 17:43
Add test to verify that all extension versions from PostgreSQL 15 can successfully upgrade to PostgreSQL 17 using pg_upgrade.The test now validates:- Each PG 15 extension version can be upgraded to PG 17- Extension update scripts are properly generated during upgrade- Version handling works correctly with and without update scripts- Final extension versions match expected values after upgrade
…ade compatibilityWhen upgrading PostgreSQL versions, pg_upgrade needs access to old extensionversions sql to migrate from. This adds unsupported pg_graphql versions (those notcompilable with current PostgreSQL) as SQL-only packages, ensuring migrationpaths exist when upgrading from older PostgreSQL versions.
…pgrade compatibilityWhen upgrading PostgreSQL versions, pg_upgrade needs access to old extensionversions sql to migrate from. This adds unsupported pg_graphql versions (those notcompilable with current PostgreSQL) as SQL-only packages, ensuring migrationpaths exist when upgrading from older PostgreSQL versions.
When upgrading from PostgreSQL 15 to 17, pg_stat_monitor version 1.0(PG 15-only) cannot be migrated as it uses .sql.in template files thatreference MODULE_PATHNAME without proper processing for the target version.This marks version 1.0 as not pg_upgrade compatible and filters it fromthe version test list, allowing the test to use version 2.1 (which supportsboth PG 15 and 17) for pg_upgrade validation instead. Version 1.0 remainsavailable for PG 15 installations.Version 2.1 has different schemas on PostgreSQL 15 vs 17 despite sharingthe same version number. On PG 15 it uses the older schema with blk_read_timeand blk_write_time columns, while on PG 17 it uses a newer schema withshared_blk_read_time, shared_blk_write_time, local_blk_read_time,local_blk_write_time and additional JIT statistics columns. During pg_upgradefrom PG 15 to 17, the extension version remains 2.1 without schema migrationsince no update script is generated. Fresh installations on PG 17 receivethe new schema while pg_upgrade retains the old schema, creating a testconflict as both scenarios share the same expected output file.A custom test implementation skips pg_regress validation after pg_upgradewhen no update script is generated, since the schema mismatch is expectedbehavior. This maintains full test coverage for fresh installations throughthe regular psql_17 check while validating extension version compatibilityfor pg_upgrade scenarios.
@yvan-srakayvan-srakaforce-pushed thefeat/test-pg-upgrade-older-version branch from29a4d56 tod36e133CompareDecember 12, 2025 08:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@samrosesamroseAwaiting requested review from samrose

Requested changes must be addressed to merge this pull request.

Assignees

@yvan-srakayvan-sraka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfroche@samrose@yvan-sraka

[8]ページ先頭

©2009-2025 Movatter.jp