Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(exts): handle pg_upgrade generated update_extensions.sql script in the extension tests#1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jfroche wants to merge56 commits intoupdate-nixpkgs
base:update-nixpkgs
Choose a base branch
Loading
fromfix/nixos-test-update-after-pg-upgrade

Conversation

@jfroche
Copy link
Collaborator

pg_upgrade may generate an update_extensions.sql script to update extensions after a major version upgrade.
This PR modifies the extension tests to check for the presence of this script after upgrading PostgreSQL to version 17.
If the script exists, it is executed to ensure that the extensions are updated correctly.

@jfrochejfroche marked this pull request as ready for reviewNovember 6, 2025 17:20
@jfrochejfroche requested review froma team ascode ownersNovember 6, 2025 17:20
@jfrochejfrocheforce-pushed thefix/nixos-test-update-after-pg-upgrade branch 2 times, most recently from28b6e73 to1a9394dCompareNovember 10, 2025 11:04
@yvan-srakayvan-srakaforce-pushed thefix/nixos-test-update-after-pg-upgrade branch from1a9394d tocecd0caCompareNovember 17, 2025 09:46
@yvan-srakayvan-sraka self-assigned thisNov 17, 2025
@yvan-srakayvan-srakaforce-pushed thefix/nixos-test-update-after-pg-upgrade branch 3 times, most recently fromdbb2ab9 to537ceefCompareNovember 21, 2025 10:37
jfrocheand others added19 commitsDecember 12, 2025 09:33
These overlay packages will be removed once the extensions are updatedto use the new `buildPgrxExtension` function.
The previously used version was failing to build:/build/source/src/common/get_check_data.c: In function 'pgr_SPI_getText':/build/source/src/common/get_check_data.c:307:28: error: passing argument 1 of 'DatumGetCString' makes integer from pointer without a cast [-Wint-conversion]  307 |     return DatumGetCString(SPI_getvalue(*tuple, *tupdesc, info.colNumber));      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      |                            |      |                            char *In file included from /build/source/include/c_common/postgres_connection.h:29,                 from /build/source/src/common/get_check_data.c:27:/nix/store/nn6vpjqlsxxmynwcrsib9agb3hpr5cqj-postgresql-17.4/include/server/postgres.h:335:23: note: expected 'Datum' {aka 'long unsigned int'} but argument is of type 'char *'  335 | DatumGetCString(Datum X)      |                 ~~~~~~^make[2]: *** [src/common/CMakeFiles/common.dir/build.make:149: src/common/CMakeFiles/common.dir/get_check_data.c.o] Error 1
We cannot use nodejs.libv8 as it is too new for plv8 3.1.We will be able to use it with plv8 3.2.
dbmate 2.27 is now using a varchar for the version column in theschema_migrations table.Seeamacneil/dbmate#641
yvan-srakaand others added24 commitsDecember 12, 2025 09:33
Updated cargo-pgrx buildPgrxExtension with rustc wrapper to handle emptypostmaster_stub.rs files that cause duplicate symbol errors.(first two filenames are `` and`/build/tmp.*/postmaster_stubs/nix/store/*/bin/postmaster_stub.rs`)pg_jsonschema cargo checks fails on specific versions (0.2.0, 0.3.1, 0.3.3).
Remove deprecated functions that were removed in newer pgrouting versions(_pgr_betweennesscentrality and _pgr_contractionhierarchies).
Improves reproducibility and avoids evaluation-time network access byusing a proper flake input instead of fetchTarball for the older nixpkgsneeded by pg_net and plv8.
…64-darwinVersion 0.19.5 has a dangling pointer issue in src/core.c:177 that causescompilation to fail on aarch64-darwin with newer clang versions. This adds-Wno-error=dangling-assignment to allow compilation to proceed.The flag is restricted to aarch64-darwin only since GCC on Linux doesn'trecognize this warning option.
Add -headerpad_max_install_names linker flag to prevent 'install_name_tool:changing install names or rpaths can't be redone' errors on macOS. Thisallocates sufficient header space for install_name_tool to modify theshared library during post-install processing.
… extensionsTest assertions were inconsistent: expecting {version}.so and {extension_name}-{version}.sopatterns while actual libraries use {lib_name}-{version}.so (e.g. pg_partman_bgw-5.3.1.so,timescaledb-loader-2.16.1.so). Updated PostgresExtensionTest to accept Optional[str] lib_nameparameter and use consistent {lib_name}-{version}.so assertions throughout.Added missing timescaledb-loader.so symlink creation and updated the switch script tomaintain both symlinks when switching versions.Fixes 'Expected timescaledb version 2.16.1, but found timescaledb-loader-2.16.1.so' and'Expected pg_partman version 5.3.1, but found pg_partman_bgw-5.3.1.so' test failures.
Use overlay instead of passing full nixpkgs-oldstable to avoid exposingentire old nixpkgs attribute set. Now provides specific packages(curl_8_4, v8_oldstable) through overlay.
Keep revision support that was accidentally simplified during nixpkgs update.Restores conditional logic to support building orioledb from specific gitrevision hashes instead of only tags.
These files were moved to subdirectories and the old .nix files should beremoved since they were moved to new directory structure with default.nix files.
Remove nixpkgs-go124 dependency since current nixpkgs has Go 1.25.4which is sufficient for packer. Remove nix-fast-build input as unusedand add follows directives to resolve duplicate dependencies.
Run flake-linter to eliminate duplicate dependencies, and remove unusedcargo-pgrx / rustc versions hashes.
Move pgrouting.nix to pgrouting/default.nix and groonga package topgroonga/groonga.nix. Update imports and fix relative paths for versions.jsonand patch files.
Replace inline bash script generation with writeShellScriptBin for rustcwrapper that filters empty postmaster_stub.rs arguments. Apply wrapper onlyfor pgrx < 0.12 since issue was fixed upstream in pgrx#1435 and pgrx#1441.
Move nixpkgs-oldstable import to a let binding to avoid importing itthree times...
Remove supabase-groonga from global flake packages and import it locallyin pgroonga extension instead. Other components access groonga viapgroonga.passthru.groonga since groonga is only used by pgroonga.
The supabase-groonga package was moved to pgroonga extension in commit1f0ed1f,but Ansible was still trying to install it separately causing build failures.
This reverts commit 55474686405394826ad07a032cbcf0e36a924554.
This reverts commit cfa9bcb92219f391469ae743f95c8856b0a99561.
Remove references to darwin.apple_sdk.frameworks.{IOKit,CoreFoundation}which have been deprecated in nixpkgs. Disable CGO to avoid Darwinframework dependencies entirely.
…n the extension testspg_upgrade may generate an update_extensions.sql script to update extensions after a major version upgrade. This commit modifies the extension tests to check for the presence of this script after upgrading PostgreSQL to version 17. If the script exists, it is executed to ensure that the extensions are updated correctly.
Thanks to the improvement related to the generated pg_upgrade script, we can now reuse the generic postgres extension test for postgis.
This helps us identify why certain extensions do not use the generic tests.
@yvan-srakayvan-srakaforce-pushed thefix/nixos-test-update-after-pg-upgrade branch from537ceef tod90c5b4CompareDecember 12, 2025 17:43
@yvan-srakayvan-sraka requested a review froma team as acode ownerDecember 12, 2025 17:43
@yvan-srakayvan-sraka changed the base branch fromdevelop toupdate-nixpkgsDecember 12, 2025 17:43
@samrosesamroseforce-pushed theupdate-nixpkgs branch 3 times, most recently from771718f to4e32d5bCompareDecember 17, 2025 19:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@samrosesamroseAwaiting requested review from samrose

Assignees

@yvan-srakayvan-sraka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfroche@yvan-sraka@samrose

[8]ページ先頭

©2009-2025 Movatter.jp