- Notifications
You must be signed in to change notification settings - Fork351
Fix compatibility to symfony 3.4.21, 4.1.10 and 4.2.2#4349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c439f7d toc4a01edComparec4a01ed to761c26bCompare761c26b to63df136Compare9c594d5 to3a525f4Compare3a525f4 tod8e8ca4CompareMemberAuthor
alexander-schranz commentedJan 8, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@wachterjohannes sulu article bundle will also crash currently:https://github.com/sulu/SuluArticleBundle/blob/5f6b4e90821f71da9179aeb7ca642d88fba1bce1/Document/Form/ArticleDocumentType.php#L37 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What's in this PR?
Fix form submit of unstructured data.
Why?
Symfony seems since the latest releasesymfony/symfony#29809 only allow scalar values be submit in the TextType.
I not really happy with the solution but currently seems the only working one.