- Notifications
You must be signed in to change notification settings - Fork856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix #2203: Improve Spanwise Section Error Handling in Turbomachinery Simulations#2459
base:develop
Are you sure you want to change the base?
Conversation
This doesn't fix issue#2203 in that the issue of incorrectly determining calculating the spanwise boundary happens because of a bug in SU2, the mesh that is used in this issue is probably fine. I have also encountered this issue and checked the CGNS mesh and it is not malformed. All this PR does is add an additional error catch, please update the description to remove the fix. |
| @@ -4974,6 +4974,13 @@ | |||
| max = 0; | |||
| SU2_MPI::Allreduce(&MyMin, &min, 1, MPI_DOUBLE, MPI_MIN, SU2_MPI::GetComm()); | |||
| SU2_MPI::Allreduce(&MyMax, &max, 1, MPI_DOUBLE, MPI_MAX, SU2_MPI::GetComm()); | |||
| if (nSpan < 2) { | |||
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
| ". Found " + to_string(nSpan) + " nodes along the periodic boundary edge from hub to shroud. " + | ||
| "At least 2 nodes are required. Check your mesh for correct hub-to-shroud edge definition.", | ||
| CURRENT_FUNCTION); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is in the equispaced section of the if statement, it should go with the other error message and run if the automatic section fails to calculate any value of nSpanWiseSections in three dimensions, i.e.
(nSpanWiseSections[INFLOW - 1] == 0 || nSpanWiseSections[OUTFLOW -1] == 0)
| buf, | ||
| CURRENT_FUNCTION); | ||
| string("Turbomachinery simulation requires equal spanwise sections at INFLOW and OUTFLOW. ") + buf + | ||
| "\nThis is likely a mesh issue. Ensure that the periodic boundaries from hub to shroud are consistently defined in the mesh.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not likely a mesh issue, it is a mesh issue!
Thank you sir for review I will do the respective changes as soon as possible. |
Proposed Changes
Fixes:#2203
This PR aims to:
This PR improves error messages for spanwise section calculations in turbomachinery simulations, addressing user experience
Related Work
Fixes#2203 : Wrong spanwise sections calculation in Turbomachinery simulation.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.