- Notifications
You must be signed in to change notification settings - Fork1.7k
Handle unexpected exits in condition polling#1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ubunatic wants to merge5 commits intostretchr:masterChoose a base branch fromubunatic:condition-polling-capture-unexpected-exit
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Handle unexpected exits in condition polling#1819
ubunatic wants to merge5 commits intostretchr:masterfromubunatic:condition-polling-capture-unexpected-exit
+313 −21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3888c76 toa55e775Comparea55e775 to5e8ff6eCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Fail
Eventually,Never, andEventuallyWithTwith"Condition exited unexpectedly"when the condition goroutine exits unexpectedly through
runtime.Goexit.Changes
Eventuallywhen condition does not return normally and fail fast instead.Neverwhen condition does not return normally to fail fast and prevent false positives.EventuallyWithTwhenruntime.Goexitwas not called throughcollect.FailNow.Motivation
Nevercurrently stops polling, when the condition exits. This can lead to false positives.Eventuallycurrently stop polling, when the condition exits. This prevents fast failures.EventuallyWithTdoes not fail when the outertfails.Related issues
This PR is a concise rewrite of#1809 and should fix Issue#1810.
Changed Behavior
EventuallyEventuallyWithTNever