NotificationsYou must be signed in to change notification settings
Fork110
Star668

Commitf84e9f8

authored

[Mac] throw js exception if iosurface fails to be created (#1567)

* [Mac] throw js exception if iosurface fails to be created* frontend already checks for an exception during surface creation. It iscleaner for us to throw in this case since this is basically a fatal error.Prevents the possibility of an undefined value being passed into node-window-rendering etc

1 parent7f518ad commitf84e9f8Copy full SHA for f84e9f8

File tree

1 file changed

-1

lines changed

obs-studio-client/source
- nodeobs_display.cpp

1 file changed

-1

lines changed

`‎obs-studio-client/source/nodeobs_display.cpp‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -335,8 +335,10 @@ Napi::Value display::OBS_content_createIOSurface(const Napi::CallbackInfo &info)`
`335`	`335`
`336`	`336`	`std::vector<ipc::value> response = conn->call_synchronous_helper("Display","OBS_content_createIOSurface", {ipc::value(key)});`
`337`	`337`
`338`		`-if (!ValidateResponse(info, response))`
	`338`	`+if (!ValidateResponse(info, response)) {`
	`339`	`+Napi::Error::New(info.Env(), response[1].value_str).ThrowAsJavaScriptException();`
`339`	`340`	`return info.Env().Undefined();`
	`341`	`+}`
`340`	`342`
`341`	`343`	`returnNapi::Number::New(info.Env(), response[1].value_union.ui32);`
`342`	`344`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf84e9f8

File tree

1 file changed

1 file changed

`‎obs-studio-client/source/nodeobs_display.cpp‎`

0 commit comments