- Notifications
You must be signed in to change notification settings - Fork1k
EEPROM emulation: wrong flash sector used for some F7 variants#938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Default configuration for F76xx and F77xx chip is single bank.But HAL define FLASH_SECTOR_TOTAL doesn't represent the real number of sector,instead, it represents the maximum number of sectors (for single and dual bank).So for variants using F76xx and F77xx chip,we must define FLASH_BASE_ADDRESS and FLASH_DATA_SECTOR in order to use the last sector of the flash corresponding to the default single bank configuration.Variants concerned: NUCLEO_F767ZI and REMRAMFixesstm32duino#297
0d1c001 toc0cfed9Comparefpistm approved these changesFeb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Thanks@ABOSTM
Bmooij pushed a commit to Bmooij/Arduino_Core_STM32 that referenced this pull requestJul 14, 2020
…duino#938)Default configuration for F76xx and F77xx chip is single bank.But HAL define FLASH_SECTOR_TOTAL doesn't represent the real number of sector,instead, it represents the maximum number of sectors (for single and dual bank).So for variants using F76xx and F77xx chip,we must define FLASH_BASE_ADDRESS and FLASH_DATA_SECTOR in order to use the last sector of the flash corresponding to the default single bank configuration.Variants concerned: NUCLEO_F767ZI and REMRAMFixesstm32duino#297
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EEPROM emulation: wrong flash sector used for some STM32F7 variants
Default configuration for F76xx and F77xx chip is single bank.
But HAL define FLASH_SECTOR_TOTAL doesn't represent the real number of sector,
instead, it represents the maximum number of sectors (for single and dual bank).
So for variants using F76xx and F77xx chip,
we must define FLASH_BASE_ADDRESS and FLASH_DATA_SECTOR in order to use the last sector of the flash corresponding to the default single bank configuration.
Variants concerned: NUCLEO_F767ZI and REMRAM
Fixes#297