Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MP1 update#774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 6 commits intostm32duino:masterfromfpistm:MP1_update
Nov 18, 2019
Merged

MP1 update#774

fpistm merged 6 commits intostm32duino:masterfromfpistm:MP1_update
Nov 18, 2019

Conversation

@fpistm
Copy link
Member

@fpistmfpistm commentedNov 15, 2019
edited
Loading

This PR:

I will probably also update the generated script name with the sketch name.
@kbumsik as discussed instm32duino/Arduino_Tools#47 (comment), do you think it is correct to use sed in the generate part of the script?
Done

Maybe I will add the MP1 Cube update 1.1.1:

  • HAL and CMIS device not changed
  • OpenAMP updated to v1.0.3

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
in engineering mode only.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm self-assigned thisNov 15, 2019
@fpistmfpistm added enhancementNew feature or request fix 🩹Bug fix labelsNov 15, 2019
@fpistmfpistm added this to the1.8.0🎄 🎅 milestoneNov 15, 2019
@kbumsik
Copy link
Contributor

@fpistm

do you think it is correct to use sed in the generate part of the script?

Yes. I tested it.

diff --git a/run_arduino_gen.sh b/run_arduino_gen.shindex 3b67ecba..2704625f 100755--- a/run_arduino_gen.sh+++ b/run_arduino_gen.sh@@ -219,10 +219,11 @@ case "$1" in     TERM=xterm minicom -D $RPMSG_DIR     ;;   generate)-    generate_packaged_script $2 $3-    echo "$(readlink -f "$3") generated successfully."+    output=$(echo "$3" | sed 's/\.ino\././g')+    generate_packaged_script $2 $output+    echo "$(readlink -f "$output") generated successfully."     echo "This file should be uploaded manually by SCP, SFTP, Kermit, or etc."-    echo "Then run \"sh ./$(basename $3) start\" command in the board's console."+    echo "Then run \"sh ./$(basename $output) start\" command in the board's console."     echo "For detailed instructions, please visit:"     echo "  https://github.com/stm32duino/Arduino_Core_STM32/tree/master/variants/STM32MP157_DK/README.md"     ;;

should work, tested in Linux and Windows.

fpistm reacted with thumbs up emoji

@fpistm
Copy link
MemberAuthor

Well,
I guess this PR could be merged when CI build will be ended.

Copy link
Contributor

@kbumsikkbumsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just spotted some while I read through the renderedREADME.md. It should be fine for me otherwise.

Co-Authored-By: Bumsik Kim <k.bumsik@gmail.com>Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm merged commit42efbeb intostm32duino:masterNov 18, 2019
@fpistmfpistm deleted the MP1_update branchNovember 18, 2019 09:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@kbumsikkbumsikkbumsik left review comments

@FCHSTMFCHSTMFCHSTM left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fpistmfpistm

Labels

enhancementNew feature or requestfix 🩹Bug fix

Projects

None yet

Milestone

1.8.0🎄 🎅

Development

Successfully merging this pull request may close these issues.

3 participants

@fpistm@kbumsik@FCHSTM

[8]ページ先頭

©2009-2025 Movatter.jp