stm32duino/Arduino_Core_STM32Public

NotificationsYou must be signed in to change notification settings
Fork1k
Star3.2k

Add SoftwareSerial#627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

armint wants to merge18 commits intostm32duino:masterfromarmint:SoftwareSerial

Closed

Add SoftwareSerial#627

armint wants to merge18 commits intostm32duino:masterfromarmint:SoftwareSerial

Conversation

Copy link

armint commentedSep 2, 2019

Summary

Add SoftwareSerial for STM32 boards.

This PR adds SoftwareSerial support for STM32 boards. The code was based on the SoftwareSerial implementation from the lpc176x arduino port and adapted for STM32. It uses the recently added HardwareTimer code for timing. The timer to be used can be defined in variant.h by defining TIMER_SERIAL. When no TIMER_SERIAL is defined it will use the simplest timer available.
Tested and working on STM32F446ZE and STM32F401RE. Works with existing SoftwareSerial example code. Tested at 9600 and 115200 baud by communicating with hardware serial interfaces and by logic analyser.

Fixes#267

armintand others added5 commits

September 2, 2019 22:08

Add SoftwareSerial

61c8da4

Use astyle to please travis-ci

775cc1e

Now used the proper astyle script to format the code

bad6546

[CI] Update configs

e638225

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Update README.md

2597961

DIYMROE STM32F407VGT toDIYMORE STM32F407VGT

fpistm requested a review fromABOSTM

September 4, 2019 07:59

fpistm added arduino compatibility enhancement

New feature or request

New feature labels

Sep 4, 2019

fpistm added3 commits

September 4, 2019 11:14

Fix{build.mcu} definition

70b8bce

Library can provide a precompiled library.See precompiled option here:https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#libraryproperties-file-formatThe .a(archive)/.so(shared object) file must be located at: `src/{build.mcu}`So the `build.mcu` could not contain `fpu` and `float-abi` optionsand should only contain `cortex-mx` value.Else Arduino IDE, instead of searching `cortex-mx`, searches`cortex-mx -mfpu=fpv4-sp-d16 -mfloat-abi=hard` if floating-pointoptions are set.`build.flags.fp` has been added to contain floating-point options if any.Fixesstm32duino#606Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Rename DIYMROE to DIYMORE

19768cc

Mistake on the silkscreen of the board. Vendor ishttps://www.diymore.cc.https://www.diymore.cc/products/stm32f4-discovery-stm32f407vgt6-microcontroller-32bit-flash-mcu-arm-cortex-m4-core-development-board?_pos=1&_sid=68a700bf4&_ss=r=Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Update README.md

513e6fa

Copy link

Contributor

ABOSTM commentedSep 4, 2019

Hi@armint,
Thank you for this pull request.
It looks really interresting, and I will make a deep review into your code.

ABOSTM suggested changes

Sep 4, 2019

View reviewed changes

Copy link

Contributor

ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In order to do like arduino with its SoftwareSerial,
could you move the files
from
cores\arduino
to
libraries\SoftwareSerial\

cores/arduino/SoftwareSerial.cpp OutdatedShow resolvedHide resolved

cores/arduino/SoftwareSerial.cppShow resolvedHide resolved

cores/arduino/SoftwareSerial.cpp OutdatedShow resolvedHide resolved

armint added2 commits

September 4, 2019 23:31

Use STM32 LL methods for IO and cleanup code

0a5067a

Move SoftwareSerial from core to libraries

86ea9bd

Copy link

Author

armint commentedSep 4, 2019

@ABOSTM Thank you for the review! I have modified the code to address the issues

armint added6 commits

September 5, 2019 00:00

Add SoftwareSerial

312289a

Use astyle to please travis-ci

d248d4d

Now used the proper astyle script to format the code

3c13a64

Use STM32 LL methods for IO and cleanup code

ac87948

Move SoftwareSerial from core to libraries

456e483

Merge branch 'SoftwareSerial' ofhttps://github.com/armint/Arduino_Co…

db6fa97

…re_STM32 into SoftwareSerial2

fpistm added this to the1.7.0 milestone

Sep 5, 2019

ABOSTM suggested changes

Sep 5, 2019

View reviewed changes

CI/build/conf/cores_config.jsonShow resolvedHide resolved

libraries/SoftwareSerial/src/SoftwareSerial.cpp Outdated

		active_out =nullptr;
		// When in half-duplex mode, we wait for HALFDUPLEX_SWITCH_DELAY bit-periods after the byte has
		// been transmitted before allowing the switch to RX mode
		}elseif (tx_bit_cnt >10 + HALFDUPLEX_SWITCH_DELAY) {

Copy link

Contributor

ABOSTMSep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that if 5 bits are required you need (

HALFDUPLEX_SWITCH_DELAY * OVERSAMPLE (old style when send() check if (--tx_tick_cnt <= 0))
(HALFDUPLEX_SWITCH_DELAY * OVERSAMPLE) - 1 (new style with if (--tx_tick_cnt < 0) )

libraries/SoftwareSerial/src/SoftwareSerial.cppShow resolvedHide resolved

libraries/SoftwareSerial/src/SoftwareSerial.cpp OutdatedShow resolvedHide resolved

fpistm added the Review on going label

Sep 6, 2019

fpistm assignedarmint

Sep 6, 2019

Copy link

Contributor

stas2z commentedSep 6, 2019

Tested it with Nucleo F103
57600 cause errors

15:58:03.187 -> _S recv: 1111111111111111111111111 : 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 0D 0A 15:58:03.319 -> MS recv: 111111111111111111111111"�� : 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 22 1A 14 15:58:03.319 -> S2 recv: 1111111111111111111111111 : 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 31 0D 0A

(where S is what was recieved from user console, MS - Software serial recieved from hardware serial, S2 - hardware serial received from software serial, serials are hardwired on the board (rx->tx))
at 115200 board doesn't boot at all

armint added2 commits

September 6, 2019 22:06

Do actual oversampling & fix delay in half duplex mode

613b4dd

Astyle

6326c05

ABOSTM mentioned this pull request

Sep 9, 2019

SoftwareSerial implementation#645

Merged

Copy link

Contributor

ABOSTM commentedSep 9, 2019

Hi@armint,
Thanks a lot for the job you have done. We really appreciate your contribution.
As it looks like you don't want to spend much more time on this, I takeover the SoftwareSerial.
So I created a new PR#645, based on your PR.
I keep you as the author as you made all the job, and you are welcome to comment on my PR if you want.