- Notifications
You must be signed in to change notification settings - Fork1k
Add STM32F446VE controller board#522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fpistm left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@petervanaken
Thanks for the contribution.
I've merged yesterday an update on how the HAL configuration is done (See#518).
I've push a branch on my fork with all fixes mentioned in this review and rebased on top of the master -->https://github.com/fpistm/Arduino_Core_STM32/tree/PR-522-reviewed
Feel free to test and customize it. I will wait your question/feedback.
When you think you variant is ready made a force pushed on your branch to update this PR.
Thanks in advance
One more thing:
Please, could you provide a link on this board?
Uh oh!
There was an error while loading.Please reload this page.
| GenF4.menu.upload_method.bmpMethod.upload.tool=bmp_upload | ||
| ############################### | ||
| Vake403d.name=VAkE 403d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is Vake403d the manufacturer name or generic branding name ?
or is the board name ?
I guess it should be best to add it to 3dprinter entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just saw in your OP the board name isVAkE v1.0
I've update my branch with this name. Let me know if it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The boads name is VAkE but will first be tested in a 3D printer called Vake403d.
The update of the branch is fine, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So, I guess the best is to use the PCB name (board name).
Vake403d is one use case of this board? right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is how I've update it:
https://github.com/fpistm/Arduino_Core_STM32/blob/50713653535c1c8dbcd38fd9ca42253fc0186f5f/boards.txt#L935-L944
# VAkE v1.03dprinter.menu.pnum.VAKE_F446VE=VAkE v1.03dprinter.menu.pnum.VAKE_F446VE.upload.maximum_size=5242883dprinter.menu.pnum.VAKE_F446VE.upload.maximum_data_size=1310723dprinter.menu.pnum.VAKE_F446VE.build.mcu=cortex-m4 -mfpu=fpv4-sp-d16 -mfloat-abi=hard3dprinter.menu.pnum.VAKE_F446VE.build.board=VAKE4033dprinter.menu.pnum.VAKE_F446VE.build.series=STM32F4xx3dprinter.menu.pnum.VAKE_F446VE.build.product_line=STM32F446xx3dprinter.menu.pnum.VAKE_F446VE.build.variant=VAKE_F446VE3dprinter.menu.pnum.VAKE_F446VE.build.cmsis_lib_gcc=arm_cortexM4l_math| # Vake F446VE | ||
| # Support: Serial1 (USART1 on PA10, PA9) | ||
| # Default SPI: SPI | ||
| Vake403d.menu.pnum.VAKE_F446VE=Vake F446VE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is It really the board name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should I change "Vake F446VE" to "VAkE" ? VAkE is infact the name of the PCB, VAke403d the name of the test printer for the PCB and since it's based on the F446...it started it's live a "Vake F446VE"
| Vake403d.menu.pnum.VAKE_F446VE.build.cmsis_lib_gcc=arm_cortexM4l_math | ||
| # Upload menu | ||
| Vake403d.menu.upload_method.STLink=STLink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since#514 STM32CubeProgrammer replace those upload method.
| Vake403d.menu.upload_method.serialMethod.upload.tool=serial_upload | ||
| Vake403d.menu.upload_method.serialMethod.build.extra_flags_serial_auto=-DMENU_SERIAL_AUTO=SerialUART1 | ||
| Vake403d.menu.usb.SerialUSB=Serial [Virtual COM port, PA11/PA12 pins] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems you worked before on STM32GENERIC core 😉
Theses definitions are not for this core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've removed the definitions. Note : next version will have the capability to use serial to upload new binaries without the need for an ST link programmer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is already the case thanks the STM32CubeProgrammer use STM32 built-in bootloader.
| /*---------------------------------------------------------------------------- | ||
| * Headers | ||
| *----------------------------------------------------------------------------*/ | ||
| #include"PeripheralPins.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No more include since#518
| #include "PeripheralPins.h" |
| /*---------------------------------------------------------------------------- | ||
| * Pins | ||
| *----------------------------------------------------------------------------*/ | ||
| externconstPinNamedigitalPin[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Define elsewhere since#518
| extern const PinName digitalPin[]; |
| // Timer Definitions | ||
| // Do not use timer used by PWM pins when possible. See PinMap_PWM. | ||
| #defineTIMER_TONE TIM6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if not needed could be removed
| #defineTIMER_TONE TIM6 | ||
| // Do not use basic timer: OC is required | ||
| #defineTIMER_SERVO TIM2 //TODO: advanced-control timers don't work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if not needed could be removed
| // pins are NOT connected to anything by default. | ||
| #defineHAVE_HWSERIAL4 | ||
| #defineHAVE_HWSERIAL1 | ||
| #defineSERIAL_PORT_MONITOR Serial4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You could use GenericSerialinstance.
Like this if USB CDC is used then this will also work
| #defineSERIAL_PORT_MONITORSerial4 | |
| #defineSERIAL_PORT_MONITORSerial |
Hi Frederic,Please find more info about the VAkE PCB :https://www.facebook.com/pages/category/Product-Service/VAkE-Board-2290066274575218/It seems TRAVIS build failed * how can I run it upfront before doing a PR ? * where can I find the root cause of failure ?Cheers,Peter ________________________________Van: Frederic Pillon <notifications@github.com>Verzonden: donderdag 16 mei 2019 16:13Aan: stm32duino/Arduino_Core_STM32CC: petervanaken; MentionOnderwerp: Re: [stm32duino/Arduino_Core_STM32] Add STM32F446VE controller board (#522)@fpistm commented on this pull request. ________________________________In boards.txt<#522 (comment)>: @@ -758,6 +758,54 @@ GenF4.menu.upload_method.bmpMethod=BMP (Black Magic Probe) GenF4.menu.upload_method.bmpMethod.upload.protocol=gdb_bmp GenF4.menu.upload_method.bmpMethod.upload.tool=bmp_upload+###############################+Vake403d.name=VAkE 403dJust saw in your OP the board name is VAkE v1.0I've update my branch with this name. Let me know if it's ok.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub<#522?email_source=notifications&email_token=ADR22BTQG6U4HBMAIJPYI6TPVVTY3A5CNFSM4HNKSKQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBY3ACEY#discussion_r284727794>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADR22BUS527TEBOKQCWY2IDPVVTY3ANCNFSM4HNKSKQQ>. |
Thanks for the link@petervanaken
To see why Travis failed simply click "Show all checks" then on "Details". |
Hi Frederic,Ok, I understand.I'll use the "RUMBA_32" as baseline to create the "VAKE v1.0" (because they share the same MCU), modify the pin numbers and VAKE specifics in the variant folder.So the new variant will appear under the "3d printer boards" in Arduino IDE next to the others.Once done and tested, I'll do a new PR.Cheers,PeterPS : as I'm currently on holiday and have no access to my hardware it will be for next week. …________________________________Van: Frederic Pillon <notifications@github.com>Verzonden: vrijdag 17 mei 2019 10:33Aan: stm32duino/Arduino_Core_STM32CC: petervanaken; MentionOnderwerp: Re: [stm32duino/Arduino_Core_STM32] Add STM32F446VE controller board (#522)Thanks for the link@petervanaken<https://github.com/petervanaken>The main issue is you do not rebased your PR on top of the master.As mentioned in my review I've merged an update few days ago. That's why it's not build as the CI build try to build the PR on top of the master.I've push a branch on my fork with all fixes mentioned in this review and rebased on top of the master -->https://github.com/fpistm/Arduino_Core_STM32/tree/PR-522-reviewedFeel free to test and customize it. I will wait your question/feedback.When you think you variant is ready made a force pushed on your branch to update this PR.I think the easiest way is you use it.To see why Travis failed simply click "Show all checks" then on "Details".—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub<#522?email_source=notifications&email_token=ADR22BXB5QG3OW4PBR6YXHTPVZUW3A5CNFSM4HNKSKQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUD45Q#issuecomment-493370998>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADR22BX57GYKKJ6CAGSTZD3PVZUW3ANCNFSM4HNKSKQQ>. |
This is done in my fork... |
😂...I didn't use the reviewed branch when cloning, now I see the "Vake" appearing in the IDE.Everything looks fine to me.What should I do to push your branch ?Cheers,Peter …________________________________Van: Frederic Pillon <notifications@github.com>Verzonden: vrijdag 17 mei 2019 13:17Aan: stm32duino/Arduino_Core_STM32CC: petervanaken; MentionOnderwerp: Re: [stm32duino/Arduino_Core_STM32] Add STM32F446VE controller board (#522)and have no access to my hardware it will be for next week.This is done in my fork...—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub<#522?email_source=notifications&email_token=ADR22BQLTFNXXQHPIICOB6LPV2H5FA5CNFSM4HNKSKQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUPNLA#issuecomment-493418156>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADR22BS2WAOW5N2D6JJVIQTPV2H5FANCNFSM4HNKSKQQ>. |
Simply push it forced on the same branch used for this PR. Note that I do not advise use master for PR. Use master to sync your fork up to date. Use an explicit branch name to make PR. |
Hi Frederic,I've tried pushing but it looks like I don't have the correct access rights or I'm doing something wrong.I've clone the repo : git clone -b PR-522-reviewedhttps://github.com/fpistm/Arduino_Core_STM32.git 1.5.0Reviewed the changes & build it.Then I tried the forced push but get an error$ git push -f masterfatal: 'master' does not appear to be a git repositoryfatal: Could not read from remote repository.Please make sure you have the correct access rightsand the repository exists.Cheers,Peter …________________________________Van: Frederic Pillon <notifications@github.com>Verzonden: vrijdag 17 mei 2019 15:19Aan: stm32duino/Arduino_Core_STM32CC: petervanaken; MentionOnderwerp: Re: [stm32duino/Arduino_Core_STM32] Add STM32F446VE controller board (#522)What should I do to push your branch ?Simply push it forced on the same branch used for this PR.You used master one.so :git push -f masterNote that I do not advise use master for PR. Use master to sync your fork up to date. Use an explicit branch name to make PR.Anyway this is done so let's continue with it ;)—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub<#522?email_source=notifications&email_token=ADR22BT3S5FPS5RUHX57BC3PV2WG7A5CNFSM4HNKSKQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUXLOA#issuecomment-493450680>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADR22BWXX5B57JXJYXS5GC3PV2WG7ANCNFSM4HNKSKQQ>. |
fpistm commentedMay 17, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Specify your git remote name of your fork. |
If you want I can submit my branch as a PR then we will review it and fix issue if any |
That's fine.Cheers, Peter …________________________________Van: Frederic Pillon <notifications@github.com>Verzonden: vrijdag 17 mei 2019 20:25Aan: stm32duino/Arduino_Core_STM32CC: petervanaken; MentionOnderwerp: Re: [stm32duino/Arduino_Core_STM32] Add STM32F446VE controller board (#522)If you want I can submit my branch as a PR then we will review it and fix issue if any—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub<#522?email_source=notifications&email_token=ADR22BVMU3WRIDF5BS6RGSLPV32DDA5CNFSM4HNKSKQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVQIUQ#issuecomment-493552722>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADR22BUNR5CLZOGAXNLY2UTPV32DDANCNFSM4HNKSKQQ>. |
Replace by#526 |
Uh oh!
There was an error while loading.Please reload this page.
Summary
This PR implements the following : Introduction of a new board called VAkE v1.0. This board is based upon the STM32F446VE. It can be used as 3D printer / CNC controller board with versatile stepper configuration.
All comments are welcome.
Cheers,
Peter