Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Malyan 3d printer variants#382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xC0000005 wants to merge22 commits intostm32duino:masterfromxC0000005:MalyanVariants

Conversation

@xC0000005
Copy link
Contributor

This adds the variants for Malyan's M200 v1 (an STM32F103 printer) and M200 v2 (STM32F070 printer). It may also work with the MP Mini Delta and Malyan M100, but those are untested. I didn't mean to add the package.json, but I can't figure out how to remove it from the PR (sorry). It's only needed for PlatformIO to download a package.

@fpistmfpistm self-requested a reviewNovember 27, 2018 19:45
@fpistmfpistm added the new variantAdd support of new bard labelNov 27, 2018
@fpistm
Copy link
Member

Hi@xC0000005
Thanks for the contributions.
I will review it soon.
About package.json
You can rebase the PR branch then remove the commit.
git rebase -i <sha1 before the commit which add the package.json>
then delete line with the "Add package.json" commit and save

@xC0000005
Copy link
ContributorAuthor

I'm working on figuring out how to rebase this (sorry for the messy history).

fpistm reacted with thumbs up emoji

Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall this is a well formed PR.
See my comments/questions.
Thanks in advance

@fpistmfpistm added the waiting feedbackFurther information is required labelDec 21, 2018
@fpistmfpistm assignedfpistm andxC0000005 and unassignedfpistmDec 21, 2018
@xC0000005
Copy link
ContributorAuthor

@fpistm - I've tested the updates on the M200 V1 and V2. If I've missed something, I'm happy to make adjustments, but I'm not sure what to do next.

Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the update.
Only one small change to do and a question.
Then I will merge it after some build tests

constPinMapPinMap_USB[]= {
{PA_11,USB,STM_PIN_DATA(STM_MODE_INPUT,GPIO_NOPULL,GPIO_AF10_USB_FS)},// USB_DM
{PA_12,USB,STM_PIN_DATA(STM_MODE_INPUT,GPIO_NOPULL,GPIO_AF10_USB_FS)},// USB_DP
{PA_13,USB,STM_PIN_DATA(STM_MODE_AF_PP,GPIO_PULLUP,GPIO_AF10_USB_FS)},// USB_NOE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is NOE used? If not then you can comment it to avoid init this pin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Any update on NOE usage ?

@xC0000005
Copy link
ContributorAuthor

xC0000005 commentedJan 28, 2019 via email

I just rebased this last night - oh, I forgot to push. Hopefully git does the right thing and figures it out.
…
On Jan 28, 2019, at 7:53 AM, Frederic Pillon ***@***.***> wrote:@fpistm commented on this pull request. In boards.txt <#382 (comment)>: > @@ -721,6 +761,54 @@ RAK.menu.upload_method.STLink.upload.tool=stlink_upload 3dprinter.menu.upload_method.serialMethod.upload.protocol=maple_serial 3dprinter.menu.upload_method.serialMethod.upload.tool=serial_upload +############################### Conflicts resolved — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#382 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aeppcb7bwfGlC65bqWPjn0cb7DggttGqks5vHxzvgaJpZM4Y2IwL>.

@fpistm
Copy link
Member

fpistm commentedJan 28, 2019•
edited
Loading

I just rebased this last night - oh, I forgot to push. Hopefully git does the right thing and figures it out.

:D
Ok will update

@xC0000005
Copy link
ContributorAuthor

xC0000005 commentedJan 28, 2019 via email

I’m sorry - I thought i already reverted this out. I’ll fix it tonight.
…
On Jan 28, 2019, at 8:11 AM, Frederic Pillon ***@***.***> wrote:@fpistm commented on this pull request. In package.json <#382 (comment)>: > @@ -0,0 +1,7 @@ +{ To remove — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#382 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeppcU9E2XVNg72EBgnxIPkcZay6TMtJks5vHyErgaJpZM4Y2IwL>.

@fpistm
Copy link
Member

I will do a clean before merge.

@xC0000005
Copy link
ContributorAuthor

xC0000005 commentedJan 28, 2019 via email

I get it - my rebase and your rebase didn’t conflict, but the result was a double definition.
…
On Jan 28, 2019, at 8:13 AM, Frederic Pillon ***@***.***> wrote: I will do a clean before merge. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#382 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeppcebHEjUmx71ShUJs-jgXNcetCdljks5vHyGkgaJpZM4Y2IwL>.

@fpistm
Copy link
Member

This PR has been rebased and cleaned in#422

@xC0000005
Copy link
ContributorAuthor

xC0000005 commentedJan 28, 2019 via email

I’ll pull it down and test when I’m home.
…
On Jan 28, 2019, at 9:08 AM, Frederic Pillon ***@***.***> wrote: This PR has been rebased and cleaned in#422 <#422> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#382 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeppcRMqje2-yM_eACPoCZUdWeRAPOGZks5vHy5ygaJpZM4Y2IwL>.

@fpistmfpistm added the abandonedNo more work on this labelJan 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fpistmfpistmfpistm requested changes

Assignees

@xC0000005xC0000005

Labels

abandonedNo more work on thisnew variantAdd support of new bardwaiting feedbackFurther information is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xC0000005@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp