- Notifications
You must be signed in to change notification settings - Fork1k
Allow boards to specify a custom startup file.#354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
xC0000005 commentedOct 9, 2018
I didn't actually want to merge the package.json, but I'm not sure how to remove the commit. I'm sorry. |
Member
fpistm commentedOct 9, 2018
Hi@xC0000005 , |
ContributorAuthor
xC0000005 commentedOct 9, 2018 via email
I did not see this, but it seems we had identical ways of going about it. Feel free to reject/close mine, your solution works perfectly well. … On Oct 9, 2018, at 1:54 PM, Frederic Pillon ***@***.***> wrote: Hi@xC0000005 <https://github.com/xC0000005> , Have you seen#353 <#353> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#354 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeppcRUbeWPR_Rh4GU7K61nTceLKZKUpks5ujQz1gaJpZM4XUDRe>. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For boards such as the Malyan M100, M200 V1 and M200 V2 (and pro) the startup assembler must account for some oddities of the bootloader which is already running. Rather than modify the core itself, allow a board to include in its -D defines a CMSIS startup file name which will be included instead.