- Notifications
You must be signed in to change notification settings - Fork1k
Change variant RemRam for final design (v1.3)#350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I had to make some backward incompatible changes: * Remove the KILL_PIN * Change SS_SD to SS_SDLCD for external SD card * Added SS_SD for on-board SD card readerSince the only development boards are in my possession,this breaking change shouldn't affect anybody.Going forward the board in version 1 is considered featurecomplete and won't change in a backward incompatible way.
fpistm approved these changesOct 4, 2018
Member
fpistm commentedOct 4, 2018
No worries. |
ContributorAuthor
hasenbanck commentedOct 4, 2018
You can merge it. The design is finished. |
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull requestApr 10, 2019
Change variant RemRam for final design (v1.3)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make some backward incompatible changes:
Since the only development boards are in my possession, this breaking change shouldn't affect anybody.
Going forward the board in version 1 is considered feature complete and won't change in a backward incompatible way.