- Notifications
You must be signed in to change notification settings - Fork1k
Remove GSM built-in library and related code#331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
GSM shield is a retired product and official library isno more supported.Moreover, this port is based on uart emulation which is notmaintained (and not functional) and will be replaced byan official SoftwareSerial port for this core. Seestm32duino#267.Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
which is not maintained (and not functional) and willbe replaced by an official SoftwareSerial port.Seestm32duino#267.Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
delayInsideIT() code should have been in the method:void GSM3SoftSerial::tunedDelay(uint16_t delay)It was introduced as an API to supportbuilt-in GSM library on Nucleo-L476RG and is not relevant for other.Fixstm32duino#250Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
11 tasks
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull requestApr 10, 2019
Remove GSM built-in library and related code
KJansun commentedNov 15, 2019
Will the GSM library added to the standard core? |
MemberAuthor
fpistm commentedNov 15, 2019
GSM shield is a retired product, so this is not planned to add a library. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.