- Notifications
You must be signed in to change notification settings - Fork1.1k
Rename some function parameters to solve -Wshadow issue in SPI and EEPROM libraries#2880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+15 −15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: marshfolx <marshfolx@outlook.com>
Signed-off-by: marshfolx <marshfolx@outlook.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm approved these changesDec 16, 2025
Member
fpistm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@marshfolx
and thanks for pointing an fixing this.
I've added an other fix see on STM32U3 series.
abc65f5 intostm32duino:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I think -Wshadow is a good feature to avoid silly mistakes, like:
I have wasted some time on my silliness recently. So I think it's good to have this warning turned on, and when I do it, SPI and EEPROM libraries make the compiler complain.
This PR just renames those parametes, nearly no cost.