Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rename some function parameters to solve -Wshadow issue in SPI and EEPROM libraries#2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 3 commits intostm32duino:mainfrommarshfolx:main
Dec 16, 2025

Conversation

@marshfolx
Copy link
Contributor

@marshfolxmarshfolx commentedDec 16, 2025
edited
Loading

I think -Wshadow is a good feature to avoid silly mistakes, like:

voidf() {boolflag= false;// some codeif(condition) {boolflag= true;    }// some more codeif(flag) {// want to do something, but flag is never true    }}

I have wasted some time on my silliness recently. So I think it's good to have this warning turned on, and when I do it, SPI and EEPROM libraries make the compiler complain.

This PR just renames those parametes, nearly no cost.

@fpistmfpistm self-requested a reviewDecember 16, 2025 07:44
marshfolxand others added3 commitsDecember 16, 2025 08:56
Signed-off-by: marshfolx <marshfolx@outlook.com>
Signed-off-by: marshfolx <marshfolx@outlook.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@marshfolx
and thanks for pointing an fixing this.
I've added an other fix see on STM32U3 series.

@github-project-automationgithub-project-automationbot moved this fromIn progress toReviewer approved inSTM32 core based on ST HALDec 16, 2025
@fpistmfpistm merged commitabc65f5 intostm32duino:mainDec 16, 2025
24 checks passed
@github-project-automationgithub-project-automationbot moved this fromReviewer approved toDone inSTM32 core based on ST HALDec 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fpistmfpistmfpistm approved these changes

Assignees

No one assigned

Labels

fix 🩹Bug fix

Projects

Milestone

2.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@marshfolx@fpistm

[8]ページ先頭

©2009-2025 Movatter.jp