Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add custom devboard - Databoard#2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 10 commits intostm32duino:mainfromits-kronos:main
Sep 23, 2025
Merged

Conversation

its-kronos
Copy link
Contributor

@its-kronosits-kronos commentedAug 29, 2025•
edited by fpistm
Loading

Summary

This PR fixes/implements the followingbugs/features

Explain themotivation for making this change. What existing problem does the pull request solve?

Since it's a custom board, it has slightly different configuration compared to the generic (16 MHZ crystal instead of 8 MHZ), which means the exported binary from arduino with generic board doesn't work to establish serial communication

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #xxx

@its-kronos
Copy link
ContributorAuthor

If there is a way to have custom pin namings, please let me know, the guide for adding a board isn't really clear on this

@its-kronos
Copy link
ContributorAuthor

also, is there a way I can test the code generated by stm32cubemx before the board gets into the offical

@fpistmfpistm added the new variantAdd support of new bard labelSep 1, 2025
@fpistmfpistm added this to the2.11.1/2.12.0 milestoneSep 1, 2025
@fpistm
Copy link
Member

If there is a way to have custom pin namings, please let me know, the guide for adding a board isn't really clear on this

You can create alias in the variant_DATABOARD.h like this:

#define My_CUSTOM_NAME PYn

#defineIO1              PA10#defineAIO10              PA5

also, is there a way I can test the code generated by stm32cubemx before the board gets into the offical

Before it gets merged?
Well if you used the git repo instead of the package you could test it with Arduino IDE.
https://github.com/stm32duino/Arduino_Core_STM32/wiki/Using-git-repository

@its-kronosits-kronos marked this pull request as draftSeptember 1, 2025 11:15
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
its-kronosand others added6 commitsSeptember 12, 2025 18:28
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
…her than genericSigned-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
… be availableCo-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: its-kronos <140297693+its-kronos@users.noreply.github.com>
@its-kronosits-kronos marked this pull request as ready for reviewSeptember 12, 2025 23:01
@its-kronosits-kronos marked this pull request as draftSeptember 12, 2025 23:03
@its-kronos
Copy link
ContributorAuthor

need to test with arduino ide using repo before making PR ready for review

@its-kronos
Copy link
ContributorAuthor

After following the instructions in the using git repo, and successfully cloning with my board in the variants folder, I do not see an option to select it in Arduino IDE

imageimage

@its-kronosits-kronos marked this pull request as ready for reviewSeptember 13, 2025 02:45
@fpistm
Copy link
Member

Hi@its-kronos

After following the instructions in the using git repo, and successfully cloning with my board in the variants folder, I do not see an option to select it in Arduino IDE

I fetch your PR and see the "databoard" in the menu.
You could try to made a "Reload Board Data" in the tools menu.
If it does not work after a restart, you could try to delete cache:
arduino/arduino-ide#1030 (comment)

@its-kronosits-kronos marked this pull request as draftSeptember 15, 2025 20:39
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.
Maybe the name "DataBoard" is too generic and can be confusing?
Is it the final name?

@github-project-automationgithub-project-automationbot moved this fromIn progress toReviewer approved inSTM32 core based on ST HALSep 16, 2025
@fpistm
Copy link
Member

fpistm commentedSep 16, 2025•
edited
Loading

As you can see it is well defined and compiled by the CI:

image

@fpistmfpistm marked this pull request as ready for reviewSeptember 16, 2025 08:24
@fpistmfpistm merged commitf1432b0 intostm32duino:mainSep 23, 2025
24 checks passed
@github-project-automationgithub-project-automationbot moved this fromReviewer approved toDone inSTM32 core based on ST HALSep 23, 2025
@its-kronos
Copy link
ContributorAuthor

Thank you so much!

I honestly couldn't believe that this works, after so much time and I can't thank you enough!

image

Again, thank you

image
fpistm reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fpistmfpistmfpistm approved these changes

Assignees

No one assigned

Labels

new variantAdd support of new bard

Projects

Milestone

2.11.1/2.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@its-kronos@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp