- Notifications
You must be signed in to change notification settings - Fork1k
Fix LINKFLAGS containing a tuple in platformio build script#2751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix LINKFLAGS containing a tuple in platformio build script#2751
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi@Stary2001 |
Hi guys, thanks for pinging. @Stary2001 Could you please share a project to reproduce the issue? |
@valeros I've made a simple reproducer here -https://github.com/Stary2001/pio-project-for-pr-2751 The extra script they use is here:https://github.com/boschsensortec/Bosch-BSEC2-Library/blob/master/extra_script.py#L18 - it iterates over LINKFLAGS to find the mcpu= argument that's being used. |
@Stary2001 thanks for a detailed reply. I've pushed your fix to PlatformIO registry. @fpistm Feel free to merge the PR. |
729b087
intostm32duino:mainUh oh!
There was an error while loading.Please reload this page.
This PR fixes an issue in the platformio build script where a tuple containing the arguments is placed into LINKFLAGS. This broke a custom script in a different project (Bosch BSEC2 sensor library) that looks at LINKFLAGS.
I'm not sure how it worked before..
I've tested this locally and it's a minor change.