Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add NUCLEO-C092RC variant#2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 4 commits intostm32duino:mainfromshowengineer:main
May 26, 2025
Merged

Add NUCLEO-C092RC variant#2735

fpistm merged 4 commits intostm32duino:mainfromshowengineer:main
May 26, 2025

Conversation

@showengineer
Copy link
Contributor

@showengineershowengineer commentedMay 22, 2025•
edited
Loading

Summary

This PR fixes/implements the followingbugs/features

  • Adding NUCLEO-C092RC board as a variant
  • MapsUSART3_IRQn andUSART4_IRQn toUSART3_4_IRQn for STM32C0 processors

Validation

  • Ensure CI build is passed.
  • Checked with CheckVariant sketch

Code formatting

  • Ensure AStyle check is passed thanks CI

Notes
I mostly copied the variant files from the NUCLEO-C071RB variant, since both chips share the same pinout and most peripherals. I have not checked if FDCAN works, all else seems to work perfectly fine.

fpistm reacted with thumbs up emoji
Copy link
Member

@fpistmfpistm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@showengineer

Thanks for the PR.
I've made a first review, could you add also the generic (clock config, boards.txt, and reference in the README.md).
And fix the astyle issues.

@fpistmfpistm added the new variantAdd support of new bard labelMay 22, 2025
@fpistmfpistm added this to the2.11.0 milestoneMay 22, 2025
@fpistmfpistm mentioned this pull requestMay 22, 2025
88 tasks
@showengineer
Copy link
ContributorAuthor

showengineer commentedMay 22, 2025•
edited
Loading

Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks...

@fpistm
Copy link
Member

Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks...

Yes but they are rules and configuration to use.
Seehttps://github.com/stm32duino/Arduino_Core_STM32/wiki/Astyle

showengineerand others added4 commitsMay 26, 2025 11:04
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Hugo <10338882+showengineer@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Hugo <10338882+showengineer@users.noreply.github.com>
Signed-off-by: Hugo <10338882+showengineer@users.noreply.github.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

I've clean up your PR:

  • remove custom PeripheralPins.c
  • apply astyle using the scripts mentioned above
  • add generic

@github-project-automationgithub-project-automationbot moved this fromIn progress toReviewer approved inSTM32 core based on ST HALMay 26, 2025
@showengineer
Copy link
ContributorAuthor

Ah thank you. Sorry, I am currently on vacation for a week without a laptop so I wasn't able to fix the rest yet.

@fpistmfpistm merged commitcb5742d intostm32duino:mainMay 26, 2025
24 of 25 checks passed
@github-project-automationgithub-project-automationbot moved this fromReviewer approved toDone inSTM32 core based on ST HALMay 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fpistmfpistmfpistm approved these changes

Assignees

No one assigned

Labels

new variantAdd support of new bard

Projects

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@showengineer@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp