- Notifications
You must be signed in to change notification settings - Fork1k
Variant addition: Nucleo-64 L412RB_P#2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fpistm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@askuric
Thanks the PR. Nice job.
Small comments to fix and ideally would prefers 2 commits one for the generic part and one for the variants.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Antun Skuric <36178713+askuric@users.noreply.github.com>
askuric commentedApr 22, 2025
Hi@fpistm, Thanks for the comments. The changes that I've done:
Accepted the changes
Is there a better way of testing. I'm planning to add two more nucleo-64 variants in the next few days so if you have some suggestions, please let me know :D |
fpistm commentedApr 22, 2025
No it is a good way to test the variant and its definitnion. As said, it is really strange you didn't see the build issue, maybe an issue in the selected target. |
fpistm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
askuric commentedApr 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok that's interesting. Now I'm having some issues with the build with the latest changes. I think that my lack of experience is catching up with my initial luck. :D |
fpistm commentedApr 22, 2025
Try to update the STLink firmware using the STM32Cube programmer thanks the "Firmware upgrade" button. |
askuric commentedApr 22, 2025
I've tried this and it did not make any difference. Is this a red flag or is it normal? Additionally, I've run some more tests, so far I've tested:
And everything seems to work as expected. |
fpistm commentedApr 22, 2025
If swd works it is linked to the Stlink firmware which provides the mass storage storage. |
askuric commentedApr 22, 2025
So then it's an issue with my setup, not the variant files right? |
fpistm commentedApr 22, 2025
Unfortunately, I do not have this board to test anyway from my point of view the PR is ok. |
fddfdeb intostm32duino:mainUh oh!
There was an error while loading.Please reload this page.
Summary
This PR adds the support for the nucleo l412rb_p variant.
And for the generic family associated with it (L412RBIxP and L412RBTxP)
It is realted to these issues:
Which have been merged within this issue:
Validation
The built-in led blinks and this is the serial output:
Code formatting
I'm happy to adapt it to your requirements if needed.