- Notifications
You must be signed in to change notification settings - Fork1k
variant(g4): Fix clock config of WeAct STM32G474CoreBoard#2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Override HSE value to 8 MHz not 24* Keep PLL input above 2.66 MHz spec* Set VCO to a multiple of USB48 and feed that from PLL, sysclk becomes 144
* Enable CRS and switch USB to HSI48, decoupling it from PLL* Increase VCO multiplier to reach 170 MHz max spec
fpistm approved these changesJan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
91b29fb intostm32duino:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
This PR fixes the following bugs:
Not touching generic_clock.cpp, that looks fine (HSI16 div4 into 150 MHz and CRS HSI48). I would like to rename its
RCC_CRSInitTypeDef pInittoRCC_CRSInitStructlike in this patch but it's up to naming convention, not relevant to compiled code.LPUART1 clocksource defaults to Pclk1, I think, no need to switch it to Sysclk or HSI or LSE (because LSE XTAL is behind DNI solderbridges).
Validation
Code formatting
CI/astyle/astyle.pylocally.Closing issues
Follow-up to#2615