- Notifications
You must be signed in to change notification settings - Fork1k
fix(hardwaretimer): avoid glitch when PWM configuration changed#2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
As all get API's use error handler if an error occur,then no need to use int as return type.Moreover, all HAL API uses uint32_tfor those value. This avoid cast issue.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
to avoid confusion.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Allow to properly set handle state.Start TIM base only if required.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Fixesstm32duino#2575.Note that the issue is that TIM_OCx_SetConfig() disablein unconditionally the N state output (TIM_CCER_CCxNE).Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
ABOSTM approved these changesNov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
32b6654 intostm32duino:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
fpistm added a commit to fpistm/STM32Examples that referenced this pull requestNov 21, 2024
TIMER_DISABLED replaced by TIMER_OUTPUT_DISABLEDSeestm32duino/Arduino_Core_STM32#2572Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm added a commit to stm32duino/STM32Examples that referenced this pull requestNov 21, 2024
TIMER_DISABLED replaced by TIMER_OUTPUT_DISABLEDSeestm32duino/Arduino_Core_STM32#2572Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#2575
issue is that
TIM_OCx_SetConfig()disable unconditionally the N state output (TIM_CCER_CCxNE), preventing tocall
setMode()fix the issue and avoid glitch.Note
This PR include some hardening and enhancement.
TIMER_DISABLEDtoTIMER_OUTPUT_DISABLED