- Notifications
You must be signed in to change notification settings - Fork1k
feat: Add variant NUCLEO-C071RB#2558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@fpistm I haveNO idea if this is correct. I could not find any guideline on how to do for Nucleos. I took a look athttps://github.com/stm32duino/Arduino_Core_STM32/pull/1745/files when doign this. It seems I should have done changes in the variant_NUCLEO_C071RB.cpp and variant_NUCLEO_C071RB.h files in some way, that I probably got wrong. I am completely ok with you updating anything in this commit manually. I have no idea how to test it. |
Hi@thernstig |
@fpistm Rebase done. Are any updates needed in the .cpp and .h file? I have no idea what is needed there. |
@thernstig |
@thernstig
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Fixesstm32duino#2537Signed-off-by: thernstig <30827238+thernstig@users.noreply.github.com>
SeeSTMicroelectronics/stm32c0xx-hal-driver#1Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
thernstig commentedNov 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fpistm thank you! If you think this looks ok I am ok to merge as well 🙂 Are you intending to release 2.9.0 soon 😄 |
Yes, in the coming days, anyway think that I've not tested this PR as I do not have the board. Anyway, I'm confident that it should work. Only a doubt about USB as it is the first time deployed on STM32C0xx series. |
f919d8c
intostm32duino:mainUh oh!
There was an error while loading.Please reload this page.
Fixes#2537