Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add variant NUCLEO-C071RB#2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 4 commits intostm32duino:mainfromthernstig:NUCLEO-C071RB
Nov 14, 2024

Conversation

thernstig
Copy link
Contributor

Fixes#2537

@thernstig
Copy link
ContributorAuthor

@fpistm I haveNO idea if this is correct. I could not find any guideline on how to do for Nucleos. I took a look athttps://github.com/stm32duino/Arduino_Core_STM32/pull/1745/files when doign this.

It seems I should have done changes in the variant_NUCLEO_C071RB.cpp and variant_NUCLEO_C071RB.h files in some way, that I probably got wrong.

I am completely ok with you updating anything in this commit manually.

I have no idea how to test it.

@fpistmfpistm added the new variantAdd support of new bard labelNov 12, 2024
@fpistmfpistm added this to the2.9.0 milestoneNov 12, 2024
@fpistmfpistm self-requested a reviewNovember 12, 2024 15:43
@fpistm
Copy link
Member

Hi@thernstig
Could you rebase this PR on the main.
It requires to get the generic to be able to build (ldscript.ld).

@thernstig
Copy link
ContributorAuthor

@fpistm Rebase done.

Are any updates needed in the .cpp and .h file? I have no idea what is needed there.

@fpistm
Copy link
Member

@thernstig
I will review this afternoon. I will made the change.

@fpistm
Copy link
Member

@thernstig
I've updated your branch.

  • fix astyle issue
  • order the pins to match board pinout (mainly Arduino Uno connector) and set the analog pins order.
  • Define the USER_BTN, LED,...
  • Add the USB support since STM32C071xx support USB. (not tested, only build enable)
thernstig reacted with heart emoji

@fpistmfpistm mentioned this pull requestNov 13, 2024
85 tasks
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

thernstigand others added4 commitsNovember 14, 2024 07:57
Fixesstm32duino#2537Signed-off-by: thernstig <30827238+thernstig@users.noreply.github.com>
SeeSTMicroelectronics/stm32c0xx-hal-driver#1Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@thernstig
Copy link
ContributorAuthor

thernstig commentedNov 14, 2024
edited
Loading

@fpistm thank you! If you think this looks ok I am ok to merge as well 🙂

Are you intending to release 2.9.0 soon 😄

@fpistm
Copy link
Member

Are you intending to release 2.9.0 soon

Yes, in the coming days, anyway think that I've not tested this PR as I do not have the board. Anyway, I'm confident that it should work. Only a doubt about USB as it is the first time deployed on STM32C0xx series.

thernstig reacted with thumbs up emoji

@fpistmfpistm merged commitf919d8c intostm32duino:mainNov 14, 2024
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[New Variant] NUCLEO-C071RB
2 participants
@thernstig@fpistm

[8]ページ先頭

©2009-2025 Movatter.jp